Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell.compiler.*: clean up maintainer sets #136376

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Sep 1, 2021

Let's remove @peti (retired) as well as @MarcWeber, @kosmikus and @lostnet who haven't
been active lately. Feel free to re-add yourself, but this should at least lessen the GitHub
notifications for now.

Add lib.teams.haskell to every maintainer list additionally. I've also
added @domenkozar and @prusnak to GHC 8.10.7 binary since they are
the only ones working on aarch64-darwin so far. Let me know if that is alright
with you.

@nh2 Do you want to be addet to GHC 8.10.2 (8.10.7?) binary as well or is
being maintainer of the muslGHCs aggregate jobset enough for you?

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pkgs/development/compilers/ghc/8.10.7-binary.nix

Let's remove peti (retired) as well Marc, Andres and Will who haven't
been active lately. Feel free to re-add yourself, but this should at
least lessen the GitHub notifications for now.

Add lib.teams.haskell to every maintainer list additionally. I've also
added Domen and Pavol to GHC 8.10.7 binary since they are the only ones
working on aarch64-darwin so far. Let me know if that is alright with
you.
@expipiplus1 expipiplus1 merged commit 96bceac into NixOS:haskell-updates Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants