Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/maddy: Add module for maddy #137260

Merged
merged 1 commit into from
Dec 7, 2021
Merged

nixos/maddy: Add module for maddy #137260

merged 1 commit into from
Dec 7, 2021

Conversation

onny
Copy link
Contributor

@onny onny commented Sep 10, 2021

Motivation for this change

Add inital and simple module for Maddy mail server, fixes #133256

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Synthetica9 Synthetica9 marked this pull request as draft September 10, 2021 11:16
@Synthetica9
Copy link
Member

Marked as draft to conform with title

@onny onny changed the title [DRAFT] nixos/maddy: Add module for maddy nixos/maddy: Add module for maddy Sep 16, 2021
@onny onny marked this pull request as ready for review September 17, 2021 09:01
@mweinelt mweinelt removed their request for review September 17, 2021 11:11
@mweinelt
Copy link
Member

Not my cup of tea.

Synthetica9
Synthetica9 requested changes Sep 17, 2021
View reviewed changes
nixos/modules/services/mail/maddy.nix Outdated Show resolved Hide resolved
nixos/modules/services/mail/maddy.nix Outdated Show resolved Hide resolved
nixos/modules/services/mail/maddy.nix Show resolved Hide resolved
nixos/modules/services/mail/maddy.nix Outdated Show resolved Hide resolved
nixos/tests/maddy.nix Outdated Show resolved Hide resolved
@onny onny force-pushed the maddy branch 2 times, most recently from cfc7f00 to 560b155 Compare September 17, 2021 15:17
@onny
Copy link
Contributor Author

onny commented Sep 17, 2021

Thank you @Synthetica9 for the feedback :)

@Synthetica9
Copy link
Member

Maybe also add a comment that the user and group will be created if they are "maddy". Looks pretty good to me otherwise, but I don't use it, so I can't really give a final verdict

@onny
Copy link
Contributor Author

onny commented Sep 17, 2021

Maybe also add a comment that the user and group will be created if they are "maddy". Looks pretty good to me otherwise, but I don't use it, so I can't really give a final verdict

Good point, I added it :)

@onny
Copy link
Contributor Author

onny commented Sep 18, 2021

The systemd unit files got merged into the maddy package. Now this module should work :)

@onny onny requested a review from lxea September 19, 2021 08:15
@onny onny requested review from davidak and globin September 30, 2021 18:40
@GoogleBot42
Copy link
Contributor

Any update on this PR?

@github-actions github-actions bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: ocaml 6.topic: python 6.topic: TeX Issues regarding texlive and TeX in general labels Dec 7, 2021
@onny onny closed this Dec 7, 2021
@onny
Copy link
Contributor Author

onny commented Dec 7, 2021

Oh no again a failed rebase :,(

@Synthetica9 Synthetica9 reopened this Dec 7, 2021
@github-actions github-actions bot removed 6.topic: ocaml 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: python labels Dec 7, 2021
@Synthetica9
Copy link
Member

(you can git pull --force to allow an external branch to override commits when you have no local work, that would've probably been the easiest option here.)

@onny @Synthetica9
nixos/maddy: Add module for maddy
ecd88f9 
Co-authored-by: Patrick Hilhorst <git@hilhorst.be>
@Synthetica9
Copy link
Member

@ofborg test maddy

@Synthetica9
Copy link
Member

(gonna merge this when ofborg is done)

@Synthetica9 Synthetica9 merged commit 29671bc into NixOS:master Dec 7, 2021
@github-actions github-actions bot mentioned this pull request Dec 7, 2021
Closed
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2021

Successfully created backport PR #149471 for release-21.11.

aanderse
aanderse reviewed Dec 8, 2021
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed this PR before it was merged. I have left some review points... better late than never. Not a big deal, but some things that would be nice to fix before promoting this to the 21.11 release branch.

nixos/modules/services/mail/maddy.nix Show resolved Hide resolved
nixos/modules/services/mail/maddy.nix Show resolved Hide resolved
nixos/modules/services/mail/maddy.nix Show resolved Hide resolved
nixos/modules/services/mail/maddy.nix Show resolved Hide resolved
nixos/modules/services/mail/maddy.nix Show resolved Hide resolved
nixos/modules/services/mail/maddy.nix Show resolved Hide resolved
nixos/modules/services/mail/maddy.nix Show resolved Hide resolved
@onny onny mentioned this pull request Dec 15, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse left review comments

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@lxea lxea Awaiting requested review from lxea

@davidak davidak Awaiting requested review from davidak

@globin globin Awaiting requested review from globin

@dasJ dasJ Awaiting requested review from dasJ

@edolstra edolstra Awaiting requested review from edolstra

@ehmry ehmry Awaiting requested review from ehmry

@FRidh FRidh Awaiting requested review from FRidh

@Gabriella439 Gabriella439 Awaiting requested review from Gabriella439

@hedning hedning Awaiting requested review from hedning

@infinisil infinisil Awaiting requested review from infinisil

@jonringer jonringer Awaiting requested review from jonringer

@jtojnar jtojnar Awaiting requested review from jtojnar

@nbp nbp Awaiting requested review from nbp

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create maddy nixos module
6 participants
@onny @Synthetica9 @mweinelt @GoogleBot42 @aanderse @SuperSandro2000