pythonPackages: removes Python2 broken packages

[superherointj]

PR is ready for review.

--

Removes all broken Python 2 packages.
114 of 265. 43% of packages broken.

If something important breaks, we can always restore it. :-)

List of broken packages

appleseed
arrow
ase
bitbucket_api
bitbucket-cli
blivet
browsermob-proxy
cairocffi
cairosvg
cherrypi
cliapp
cmdtest
coilmq
construct
django_evolution
docker-py
dulwich
flask
flask_ldap_login
flit
flit-core
fontforge
gdcm
geant4
google-api-python-client
gdrivefs
hg-git
hgsvn
imagecodecs-lite
imbalanced-learn
ipykernel
ipython
jsonrpclib
jupyter_client
jupyter_console
koji
kicad
larch
Lasagne
ldaptor
libcloud
libgpiod
libvirt 
lirc
lpod
lsi
mapsplotlib
marionette-harness
marionette_driver
matplotlib
mercurial
meson
mlt
moinmoin
monosat
mozprofile
mozrunner
mozsvc
mwlib
mwlib-rl
nbformat
nevow
nixpart0
nixpart
notebook
nxt-python
openwrt-luci-rpc
pandas
#pillow <- Delayed removal
postorius
praw
privacyidea-ldap-proxy
pycangjie
pycarddav
pyexiv2
pykickstart
python-otr
pythonIRClib
pythonmagick
pyutil
qserve
remotecv
rivet
robotframework-ride
runsnakerun
rpm
rpkg
scikit-learn
scipy
seaborn
serversyncstorage
sequoia
sipsimple
smartdc
snug
sphinx
squaremap
subliminal
suds
tarman
thumbor
tokenizers
tokenize-rt
tokenserver
ttystatus
wptserve
werkzeug
wxPython
wxPython30 <- Removal delayed
vcrpy
xenomapper
yt
zeek
zbase32
zfec

[SuperSandro2000]

Please put all the commits that move packages to python3 into extra PRs.

[superherointj]

Please put all the commits that move packages to python3 into extra PRs.

Hello @SuperSandro2000

I have only fixed package plover for Python3 and it's already a separate commit.
This PR is mostly about removing packages or marking as broken packages.
First commit (pythonPackages: remove python2 broken packages) is a compilation of the removal of all Python 2 broken packages. All other commits were packages that depended on any of these packages. And were also broken by extension.

[doronbehar]

LGTM to me overall, but it'd be nice to get a second 👍 from someone else.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/608

[superherointj]

Please don't remove displaycal. It works fine and I need it to color calibrate my display.

@peti I have restored displaycal, wxPython_3, pillow.

This ideally should be solved on upstream. If this application is important to you, consider fixing it on upstream. (Forking, crowdsourcing, etc.)

[rnhmjoj]

This need a mention in the release notes and aliases that explain why the packages have been removed.

[superherointj]

This need a mention in the release notes and aliases that explain why the packages have been removed.

This what? Can you be more specific?
This PR is affecting broken packages mostly.
wxPython was renamed to wxPython_3 and wxPython became latest (as is expected) but all occurrences were accounted and fixed (used ripgrep for this).
Is this what you mean?

I'm not sure it is worth replacing a list of broken packages with aliases saying it is broken. It was already broken. The goal is to do clean-up.

[rnhmjoj]

This what? Can you be more specific?

This pull request: it would be good to have a release note saying all broken Python 2 packages have been removed.

This PR is affecting broken packages mostly.
wxPython was renamed but all occurrences were accounted and fixed

Any package being removed or renamed needs an alias: https://nixos.org/manual/nixpkgs/stable/#steps-to-remove-a-package-from-nixpkgs

[superherointj]

Any package being removed or renamed needs an alias: https://nixos.org/manual/nixpkgs/stable/#steps-to-remove-a-package-from-nixpkgs

I don't think it makes sense in this case because packages were already broken and this is clean-up. This PR is even removing some aliases. The goal is to lower the noise. Packages that have hope of being saved were marked as being broken. I'm not adding 114 aliases (for no good reason).

[superherointj]

This pull request: it would be good to have a release note saying all broken Python 2 packages have been removed.

Will seek to it. As Highlights or Backward Incompatibilities or Other Notable Changes?

[rnhmjoj]

I don't think it makes sense in this case because packages were already broken and this is clean-up.

Broken since when? If in the last couple of releases they were ok, a user upgrading to 21.11 will get an error like:

error: undefined variable 'torchar'...

which doesn't say if the package was removed, renamed or the reason why it's missing. Say she then reads the release notes and finds no mention of any of this, double check for typos and finally, after wading through the PRs, figures it was deleted here. It's definitely not a good experience, so that's why it's a good reason.

This PR is even removing some aliases

Yeah, you can guess I'm not a fan of doing this.

[davidak]

displaycal should not be removed, since people depend on it for their professional work

it's the only tool available to calibrate the display (except gnome color management)

[superherointj]

displaycal should not be removed, since people depend on it for their professional work

it's the only tool available to calibrate the display (except gnome color management)

It has been reversed already.

[superherointj]

I have changed my mind on this PR. There is opposition for it. And it needs further improvements that I'm unwilling. So I'm closing. I'm sorry people that contributed for it. I should have had a better judgement here.