element-desktop: fix "Sqlcipher support is missing" #153279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/element-desktop-search-not-working/16921/5 |
|
Result of 2 packages built:
|
ofborg
bot
requested review from
fadenb,
Ralith,
mguentner,
dali99,
sumnerevans,
Ekleog,
mjlbach and
Ma27
sumnerevans
approved these changes
Jan 3, 2022
|
Umm does this also need a backport? 👀 It's a non-breaking fix for an issue |
|
Probably wouldn't hurt to backport. We backport updates to Element because it's fairly essential to keep it up-to-date to eliminate potential vulnerabilities. |
dasJ
added
9.needs: port to stable
1 task
|
Successfully created backport PR #155480 for |
|
The process '/usr/bin/git' failed with exit code 1 |
|
Thanks so much for this. I had to reset the search cache before it started working for me but now it's up and running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Forum post noted encrypted message search is not working any more. Upstream issue is matrix-org/seshat#102.
For now this successfully works around the problem. As noted in the upstream issue it may be possible for the ultimate fix to be on Element's end, as Signal did.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes