-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible: prune old versions; restructure #166447
Conversation
4dc6be4
to
68a53d0
Compare
I was about to submit a simple PR to update ansible and ansible-core: But then I found this PR. I'd be happy to help test these changes and contribute, although I've just started learning Nix. |
68a53d0
to
8eefc54
Compare
Feel free to submit this as a separate PR. |
@ofborg eval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
pkgs/top-level/all-packages.nix
Outdated
ansible = ansible_2_12; | ||
ansible_2_12 = python3Packages.toPythonApplication python3Packages.ansible-core; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ansible = ansible_2_12; | |
ansible_2_12 = python3Packages.toPythonApplication python3Packages.ansible-core; | |
ansible = python3Packages.toPythonApplication python3Packages.ansible-core; |
Might as well. I don't want to support multiple ansible versions in the future if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like (and need) the option to have multiple versions of Ansible. However only those that are supported upstream make sense. Ansible will be officially deprecating 2.9.x next month (in May 2022): https://groups.google.com/g/ansible-announce/c/kegIH5_okmg/?pli=1. So dropping ansible 2.9 and 2.10 make sense, while 2.11 and 2.12 are actively supported and used in the wild.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but neither me nor mweinelt want to maintain more versions than necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracking multiple ansible versions is not unusual, so I will keep this as is.
With 2.11 I decided to drop it, because we can't support it throughout the 22.05 release.
- Drop pkgs/tools/admin/ansible and move everything into top-level and throws into central aliases.nix - Drop the Ansible 2.8 throw - Remove Ansible 2.9/2.10, both will be EOL before the 22.05 release - Remove Ansible 2.11, it will go EOL during the 22.05 release - Expose the collections as `python3Packages.ansible` Closes: NixOS#157591
8eefc54
to
0f946e2
Compare
Description of changes
python3Packages.ansible
Closes: #157591
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes