Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible: prune old versions; restructure #166447

Merged
merged 5 commits into from
Apr 26, 2022
Merged

ansible: prune old versions; restructure #166447

merged 5 commits into from
Apr 26, 2022

Conversation

mweinelt
Copy link
Member

Description of changes
  • Drop the Ansible 2.8 throw
  • Remove Ansible 2.9/2.10, both will be EOL before the 22.05 release
  • Remove Ansible 2.11, it will go EOL during the 22.05 release
  • Expose the collections as python3Packages.ansible

Closes: #157591

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt added this to To do in Picking up garbage via automation Mar 30, 2022
@mweinelt mweinelt added this to To do in 22.05 Blockers via automation Mar 30, 2022
@mweinelt mweinelt moved this from To do to In progress in 22.05 Blockers Apr 4, 2022
@senorsmile
Copy link
Contributor

I was about to submit a simple PR to update ansible and ansible-core:
master...senorsmile:ansible-core-2.12.5

But then I found this PR.

I'd be happy to help test these changes and contribute, although I've just started learning Nix.

@mweinelt
Copy link
Member Author

I was about to submit a simple PR to update ansible and ansible-core: master...senorsmile:ansible-core-2.12.5

But then I found this PR.

I'd be happy to help test these changes and contribute, although I've just started learning Nix.

Feel free to submit this as a separate PR.

@senorsmile senorsmile mentioned this pull request Apr 25, 2022
Merged
13 tasks
@mweinelt
Copy link
Member Author

@ofborg eval

SuperSandro2000
SuperSandro2000 reviewed Apr 25, 2022
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

pkgs/development/python-modules/ansible/core.nix Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated
Comment on lines 14663 to 14664
ansible = ansible_2_12;
ansible_2_12 = python3Packages.toPythonApplication python3Packages.ansible-core;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ansible = ansible_2_12;
ansible_2_12 = python3Packages.toPythonApplication python3Packages.ansible-core;
ansible = python3Packages.toPythonApplication python3Packages.ansible-core;

Might as well. I don't want to support multiple ansible versions in the future if possible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like (and need) the option to have multiple versions of Ansible. However only those that are supported upstream make sense. Ansible will be officially deprecating 2.9.x next month (in May 2022): https://groups.google.com/g/ansible-announce/c/kegIH5_okmg/?pli=1. So dropping ansible 2.9 and 2.10 make sense, while 2.11 and 2.12 are actively supported and used in the wild.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but neither me nor mweinelt want to maintain more versions than necessary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracking multiple ansible versions is not unusual, so I will keep this as is.

With 2.11 I decided to drop it, because we can't support it throughout the 22.05 release.

@mweinelt
ansible: prune old versions; restructure
0f946e2 
- Drop pkgs/tools/admin/ansible and move everything into top-level and
  throws into central aliases.nix
- Drop the Ansible 2.8 throw
- Remove Ansible 2.9/2.10, both will be EOL before the 22.05 release
- Remove Ansible 2.11, it will go EOL during the 22.05 release
- Expose the collections as `python3Packages.ansible`

Closes: NixOS#157591
@mweinelt mweinelt merged commit 5f3eeb9 into NixOS:master Apr 26, 2022
Picking up garbage automation moved this from To do to Done Apr 26, 2022
22.05 Blockers automation moved this from In progress to Done Apr 26, 2022
@mweinelt mweinelt deleted the ansible-cleanup branch April 26, 2022 12:04
@ralismark ralismark mentioned this pull request Apr 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajs124 ajs124 ajs124 left review comments

@senorsmile senorsmile senorsmile left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
Picking up garbage
Status: Done
22.05 Blockers
Done
Picking up garbage
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Ansible 2.9 and 2.10
4 participants
@mweinelt @senorsmile @ajs124 @SuperSandro2000