config.allowAliases: Define as option #166792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies usages and makes the default value consistent. In a few cases, the default value was interpreted to be `false`, but this is useless, because virtually nobody will explicitly set `allowAliases = true;`.
roberth
requested review from
zowoq,
piegamesde,
jtojnar,
hedning,
jonringer,
infinisil,
ttuegel,
stigtsp,
zakame,
FRidh,
Lassulus,
Profpatsch,
nbp,
Ericson2314 and
matthewbauer
as code owners
github-actions
bot
added
6.topic: GNOME
13 tasks
|
I think we should do this for all config options used in nixpkgs. And then generate documentation out of it like we do with the nixos modules. See also #56227 which takes it even further (though maybe a bit too far with use flags). |
FRidh
approved these changes
Apr 4, 2022
|
https://hydra.nixos.org/eval/1753299#tabs-removed Seems this broke |
roberth
added a commit
to hercules-ci/nixpkgs
that referenced
this pull request
Apr 8, 2022
NixOS#166792 made the aliases work, which was unexpected for terraform-full. Thanks to zowoq for reporting NixOS#166792 (comment)
zimbatm
pushed a commit
that referenced
this pull request
Apr 9, 2022
#166792 made the aliases work, which was unexpected for terraform-full. Thanks to zowoq for reporting #166792 (comment)
zhaofengli
added a commit
to zhaofengli/colmena
that referenced
this pull request
Apr 25, 2022
… config keys This was added in NixOS/nixpkgs#166792. Fixes #74.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/where-are-options-like-config-cudasupport-documented/17805/4 |
13 tasks
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and description
This simplifies usages and makes the default value consistent.
In a few cases, the default value was interpreted to be
false,but this is useless, because virtually nobody will explicitly
set
allowAliases = true;.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes