hw-probe: init at 1.6.4 #168787

rehno-lindeque · 2022-04-15T13:51:51Z

Description of changes

A tool to probe for hardware, check operability and find drivers with the help of Linux hardware database.

Results can be uploaded to the database used by https://linux-hardware.org/ (or https://bsd-hardware.info/)

hw-probe was previously mentioned on /r/NixOS: People appear to use docker to run it on NixOS.

Things done

rehno-lindeque · 2022-04-15T13:54:23Z

pkgs/tools/system/hw-probe/default.nix

+, edid-decode
+
+# Recommended
+, withRecommended ? false # Install recommended tools


I left this as false because I noticed that a similar flag is false for inxi:

nixpkgs/pkgs/tools/system/inxi/default.nix

Line 3 in 590fa80

, withRecommends ? false # Install (almost) all recommended tools (see --recommends)

Not sure what best practice is

If you use the tool normally would you always want those programs? If yes, it should be true.

Gotcha, I'll fix this

rehno-lindeque · 2022-04-15T13:56:01Z

pkgs/tools/system/hw-probe/default.nix

+, withSuggested ? false # Install (most) suggested tools
+, hplip
+, sane-backends
+, pnputils ? null # pnputils (lspnp) isn't current in nixpkgs and appears to be poorly maintained


Note that pnputils is not available in nixpkgs and appears to have been removed from debian I think it was - for being poorly maintained

rehno-lindeque · 2022-04-15T13:57:20Z

pkgs/tools/system/hw-probe/default.nix

+        memtester
+        sysstat # (iostat)
+        cpuid
+        util-linuxMinimal # (rfkill)


I've used util-linuxMinimal instead of util-linux to copy similar code in inxi. Not sure what best practice is

util-linuxMinimal is probably just for bootstrapping systemd and related friends. Shouldn't matter ot much which we use if minimal has the features compiled in.

pkgs/tools/system/hw-probe/default.nix

linuxhw · 2022-04-16T00:51:41Z

pkgs/tools/system/hw-probe/default.nix

+      recommendedPrograms = [
+        mcelog
+        hdparm
+        systemd # (systemd-analyze)


I don't think it's a good idea to require installation of systemd.

The tool should probe for systemd-analyze only if systemd is already installed and used by the computer owner.

Thanks @linuxhw - seeing you helpfully drop by motivates me to try and get the PR accepted.

I don't think it's a good idea to require installation of systemd.

The tool should probe for systemd-analyze only if systemd is already installed and used by the computer owner.

Fair enough, I should probably add a systemdSupport input argument to support non-NixOS use cases.

(Note that nix has a slightly different interpretation of "installation" which means something more like "make binaries available in a specific context", rather than what I would call "activation". Never-the-less your point is well taken.)

Quick suggestion that may require a separate PR to make the change treewide:

How do others feel about a nixpkgs config flag for config.systemdSupport so that the input argument can be implemented as systemdSupport ? config.systemdSupport or stdenv.isLinux?

I.e. config.systemdSupport would be similar to other nixpkgs config flags like config.cudaSupport.

I've noticed that some other packages have input flags like systemdSupport ? stdenv.isLinux or systemdSupport ? stdenv.hostPlatform.isLinux. However I've personally worked with nix + non-systemd linux, so I find that default to be a little off target.

Related: There are well defined config options now #166792

pkgs/tools/system/hw-probe/default.nix

rehno-lindeque · 2022-04-17T15:45:55Z

pkgs/tools/system/hw-probe/default.nix

+        ++ lib.optionals withRecommended recommendedPrograms
+        ++ lib.optionals withSuggested suggestedPrograms;
+    in [
+      "--set" "PERL5LIB" "${makePerlPath [ LWP ]}"


I don't know much about perl - I'm guessing LWPProtocolHttps is not necessary since hw-probe just specifies libwww-perl (?)

rehno-lindeque · 2022-04-17T16:17:01Z

@linuxhw Since you're around, I thought I'd just check.

I appear to be missing these logs:

I'm guessing these are all just due to boot flags and things of that nature rather than anything packaging related?

Biosdecode: Here's the binary from dmidecode

$ nix-shell -p dmidecode --run 'ls -l $(which biosdecode) ; printf "VERSION: " ; biosdecode --version'
-r-xr-xr-x 1 root root 27680 Dec 31  1969 /nix/store/vqd0a65pxla9qnas0bq7i8rfgmadizxz-dmidecode-3.2/bin/biosdecode
VERSION: 3.2

I2cdetect: Binary from i2c-tools. I'm guessing this is not a problem and I simply don't have any i2c busses on my laptop.

$ nix-shell -p i2c-tools --run 'ls -l $(which i2cdetect) ; printf "LIST: " ; i2cdetect -l'
-r-xr-xr-x 1 root root 30792 Dec 31  1969 /nix/store/98js1cgw8g4pa2xigqg6nn3fvwicgwwn-i2c-tools-4.3/bin/i2cdetect
LIST:

mcelog: Binary from mcelog

$ nix-shell -p mcelog --run 'ls -l $(which mcelog) ; printf "VERSION: " ; mcelog --version'
-r-xr-xr-x 1 root root 166384 Dec 31  1969 /nix/store/4xgy1v8pl0sb8vnrnrv1v58kbkjs19kk-mcelog-178/bin/mcelog
VERSION: mcelog 178

Xorg.log: I'm not sure about this one. I think these logs are available via journalctl -b -u display-manager.service

winny- · 2022-06-19T02:29:06Z

EDIT: Added more missing packages. For some reason hdparm results are not appearing yet.

Hello, I recently created a PR to also package hw-probe, however, decided to close it after realizing this one exists.

hw-probe is a bit of a prickly package because it looks for several tools that are assumed to be installed and are not explicitly declared as dependencies by the project. For this reason I suggest testing using a command like the following:

sudo -E env PATH= $(nix-build --pure -A hw-probe)/bin/hw-probe -all -upload

Did a little testing and found most of the perl packages needed:

LWPProtocolHttps
HTTPMessage
HTTPDate
URI

hw-probe also needs the following if ran in a pure environment:

gnutar (omitting this will manifest in a failed tar invocation being silently ignored causing a more confusing error message)
xz (or gzip)
iproute2  (or inetutils - either ip or ifconfig is needed)
coreutils (ls, sort)
gnugrep (grep)
kmod (lsmod)

Here's the branch comparison (diff) from this PR branch that includes the above changes: rehno-lindeque/nixpkgs@hw-probe-1.6.4...winny-:hw-probeIsolatedBuildFixup

Example probe using the above pure nix build incantation: https://linux-hardware.org/?probe=5f385cfbee

rehno-lindeque · 2022-06-20T23:09:11Z

@winny- thank you for this, I'll review and cherry-pick into my branch as soon as possible.

(I'm traveling so it might be a little while)

rehno-lindeque · 2022-08-21T21:09:00Z

Finally got around to cherry picking your additions, thanks @winny-. I'll ask on discourse for a review since no one has looked at this yet.

nixos-discourse · 2022-08-21T21:14:31Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1126

pkgs/tools/system/hw-probe/default.nix

SuperSandro2000 · 2022-08-21T22:39:08Z

pkgs/tools/system/hw-probe/default.nix

+, edid-decode
+
+# Recommended
+, withRecommended ? false # Install recommended tools


If you use the tool normally would you always want those programs? If yes, it should be true.

pkgs/tools/system/hw-probe/default.nix

SuperSandro2000 · 2022-08-21T22:40:17Z

pkgs/tools/system/hw-probe/default.nix

+        memtester
+        sysstat # (iostat)
+        cpuid
+        util-linuxMinimal # (rfkill)


util-linuxMinimal is probably just for bootstrapping systemd and related friends. Shouldn't matter ot much which we use if minimal has the features compiled in.

pkgs/tools/system/hw-probe/default.nix

pkgs/top-level/all-packages.nix

rehno-lindeque · 2022-08-22T01:54:13Z

@SuperSandro2000 thank you, suggestions applied. I'm happy to squash and rebase if everything looks good?

SuperSandro2000 · 2022-08-24T20:08:43Z

Can you squash the hw-probe review commits into the init commit? Other than that LGTM.

rehno-lindeque · 2022-08-25T16:59:05Z

@SuperSandro2000 hw-probe commits squashed, and rebased on master.

Should be good to merge now

FlorianFranzen · 2022-11-14T23:00:20Z

It seems the vulkan-utils derivation is actually empty, did you mean to use vulkan-tools?

rehno-lindeque · 2022-11-17T14:17:07Z

Hmm, thank you for pointing that out @FlorianFranzen, this is a bit of a 🤦‍♂️ moment. I'll create a PR to remove vulkan-utils and replace the input.

I'm not 100% sure, but based on linuxhw/hw-probe@1d743ad I think it may be used for glxgears / glxinfo / etc...

@linuxhw By the way, I think that this should be vulkan-tools in the hw-probe installation instructions as well:

It seems like vulkan-utils (previously KhronosGroup/Vulkan-LoaderAndValidationLayers?) is replaced by vulkan-tools (or KhronosGroup/Vulkan-Tools)

rehno-lindeque commented Apr 15, 2022

View reviewed changes

pkgs/tools/system/hw-probe/default.nix Outdated Show resolved Hide resolved

rehno-lindeque force-pushed the hw-probe-1.6.4 branch from b523e79 to 46b9c27 Compare April 15, 2022 14:05

ofborg bot added 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 15, 2022

linuxhw reviewed Apr 16, 2022

View reviewed changes

rehno-lindeque force-pushed the hw-probe-1.6.4 branch 2 times, most recently from 1fe3658 to ad9db13 Compare April 17, 2022 14:58

rehno-lindeque commented Apr 17, 2022

View reviewed changes

pkgs/tools/system/hw-probe/default.nix Outdated Show resolved Hide resolved

ofborg bot added the 11.by: package-maintainer label Apr 17, 2022

rehno-lindeque force-pushed the hw-probe-1.6.4 branch from ad9db13 to 77c8f34 Compare April 17, 2022 15:38

rehno-lindeque commented Apr 17, 2022

View reviewed changes

Luz mentioned this pull request Jun 18, 2022

hw-probe: init at 1.6.4 #177254

Closed

13 tasks

SuperSandro2000 reviewed Aug 21, 2022

View reviewed changes

rehno-lindeque force-pushed the hw-probe-1.6.4 branch from 2f72e4e to b5b10d5 Compare August 22, 2022 01:42

ofborg bot removed the 10.rebuild-linux: 1 label Aug 22, 2022

rehno-lindeque requested a review from SuperSandro2000 August 23, 2022 12:30

rehno-lindeque added 2 commits August 25, 2022 12:48

maintainers: add rehno-lindeque

59e7439

hw-probe: init at 1.6.4

75424ac

vulkan-utils: init at 0.5.7

864b23a

rehno-lindeque force-pushed the hw-probe-1.6.4 branch from 0d1c0b4 to 864b23a Compare August 25, 2022 16:57

SuperSandro2000 merged commit c59d300 into NixOS:master Aug 25, 2022

rehno-lindeque mentioned this pull request Nov 17, 2022

hw-probe: replace vulkan-utils -> vulkan-tools to fix incorrect dependency #201635

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hw-probe: init at 1.6.4 #168787

hw-probe: init at 1.6.4 #168787

rehno-lindeque commented Apr 15, 2022

rehno-lindeque Apr 15, 2022

SuperSandro2000 Aug 21, 2022

rehno-lindeque Aug 22, 2022

rehno-lindeque Apr 15, 2022

rehno-lindeque Apr 15, 2022 •

edited

Loading

SuperSandro2000 Aug 21, 2022

linuxhw Apr 16, 2022

rehno-lindeque Apr 17, 2022 •

edited

Loading

rehno-lindeque Apr 29, 2022

rehno-lindeque Apr 17, 2022

rehno-lindeque commented Apr 17, 2022 •

edited

Loading

winny- commented Jun 19, 2022 •

edited

Loading

rehno-lindeque commented Jun 20, 2022

rehno-lindeque commented Aug 21, 2022

nixos-discourse commented Aug 21, 2022

SuperSandro2000 Aug 21, 2022

SuperSandro2000 Aug 21, 2022

rehno-lindeque commented Aug 22, 2022 •

edited

Loading

SuperSandro2000 commented Aug 24, 2022

rehno-lindeque commented Aug 25, 2022

FlorianFranzen commented Nov 14, 2022

rehno-lindeque commented Nov 17, 2022 •

edited

Loading

hw-probe: init at 1.6.4 #168787

hw-probe: init at 1.6.4 #168787

Conversation

rehno-lindeque commented Apr 15, 2022

Description of changes

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rehno-lindeque Apr 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rehno-lindeque Apr 17, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rehno-lindeque commented Apr 17, 2022 • edited Loading

winny- commented Jun 19, 2022 • edited Loading

rehno-lindeque commented Jun 20, 2022

rehno-lindeque commented Aug 21, 2022

nixos-discourse commented Aug 21, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rehno-lindeque commented Aug 22, 2022 • edited Loading

SuperSandro2000 commented Aug 24, 2022

rehno-lindeque commented Aug 25, 2022

FlorianFranzen commented Nov 14, 2022

rehno-lindeque commented Nov 17, 2022 • edited Loading

rehno-lindeque Apr 15, 2022 •

edited

Loading

rehno-lindeque Apr 17, 2022 •

edited

Loading

rehno-lindeque commented Apr 17, 2022 •

edited

Loading

winny- commented Jun 19, 2022 •

edited

Loading

rehno-lindeque commented Aug 22, 2022 •

edited

Loading

rehno-lindeque commented Nov 17, 2022 •

edited

Loading