-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-sdk-cpp: include dev output as header path hint #182918
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-burns
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix, LGTM
smancill
reviewed
Aug 15, 2022
jonringer
force-pushed
the
fix-aws-sdk-cpp-find
branch
from
August 24, 2022 15:58
9486877
to
8331c12
Compare
Merging once green |
Ping, merge conflict but still LGTM otherwise |
jonringer
force-pushed
the
fix-aws-sdk-cpp-find
branch
from
October 15, 2022 19:13
8331c12
to
b243900
Compare
rebased on master |
Artturin
force-pushed
the
fix-aws-sdk-cpp-find
branch
from
July 20, 2023 04:42
b243900
to
6e4cf85
Compare
ofborg
bot
added
10.rebuild-linux: 501+
10.rebuild-linux: 501-1000
and removed
10.rebuild-linux: 101-500
labels
Jul 20, 2023
Artturin
force-pushed
the
fix-aws-sdk-cpp-find
branch
from
July 20, 2023 19:21
6e4cf85
to
7c0dac6
Compare
Wrong indentation in the cmake file, but indentation in those are just visual AFAIK
|
Artturin
force-pushed
the
fix-aws-sdk-cpp-find
branch
from
July 23, 2023 00:33
7c0dac6
to
f7557ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This includes the dev output in the hints to find the
aws/core/Aws.h
header.Before this change, you would likely need to pass
AWS_CORE_HEADER_FILE
explicitly.This is especially useful when using the
find_package(AWSSDK)
workflow.Usage of individual targets is still pretty painless as
install(TARGETS
respects the $out + $dev split we do.Related upstream issue: aws/aws-sdk-cpp#2009
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes