Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hatch: init at 1.3.1 #185214

Merged
merged 1 commit into from
Aug 17, 2022
Merged

hatch: init at 1.3.1 #185214

merged 1 commit into from
Aug 17, 2022

Conversation

onny
Copy link
Contributor

@onny onny commented Aug 5, 2022

Description of changes

Fixes #182726

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mweinelt
Copy link
Member

mweinelt commented Aug 5, 2022

This should probably be next to https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/hatchling/default.nix

This is the project management CLI, not a library anyone would import, so I disagree. Please make your case.

Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

pkgs/development/tools/hatch/default.nix Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is the project management CLI, not a library anyone would import, so I disagree. Please make your case.

it is from the same repository and very closely related.
hatcling https://github.com/pypa/hatch/tree/master/backend
hatch https://github.com/pypa/hatch

@mweinelt
Copy link
Member

mweinelt commented Aug 6, 2022

pkgs/tools/package-management/{conda,pdm}

@ofek
Copy link
Contributor

ofek commented Aug 7, 2022

@SuperSandro2000
Copy link
Member

pkgs/tools/package-management/{conda,pdm}

yeah, true. Well, whatever. Just follow that.

@SuperSandro2000 SuperSandro2000 merged commit a718e26 into NixOS:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packaging request: hatch
4 participants