Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/backport: Copy security label in backport PRs #219810

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Mar 6, 2023

Since v1.2.0 the backport action supports copying labels from the source to the backport PR. This is useful for copying the security label from the original PR to the backport PR, so relevant security updates don't get lost.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Since v1.2.0 the backport action supports copying labels from the source
to the backport PR. This is useful for copying the security label from
the original PR to the backport PR, so relevant security updates don't
get lost.
Copy link
Member

@lheckemann lheckemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooo!

I'm happy to merge this as is, but maybe we should copy all severities?

@mweinelt
Copy link
Member Author

mweinelt commented Mar 6, 2023

I can't remember having seen the mass rebuild severity assign anywhere. And the blocker label is usually only assigned to issues, which then appear on s.n.o.

I think scratching the security itch now is paramount. Everything else can come later, when we deem it necessary.

@lheckemann lheckemann merged commit 6787f14 into NixOS:master Mar 6, 2023
@mweinelt mweinelt deleted the backport-security-label branch March 6, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants