deno: 1.31.1 -> 1.32.3

[06kellyjac]

Description of changes

Bump deno to 1.32.4
Some other fixes detailed in comment below

Draft until ofborg confirms it builds all good for all platforms

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[06kellyjac]

Depends on std::pin::pin! stabilized in rust 1.68 - #220373

[06kellyjac]

1.32.0 out. I've not checked but it's almost certain it is still using 1.68 only features so the above still applies

[LeSuisse]

For information the 1.31.2 contains the fix for CVE-2023-28446.

[06kellyjac]

I guess I'll need to do a separate PR then. Fingers crossed it doesnt need the new rust release 🙃

[levex]

hey @06kellyjac, I've locally updated default.nix to 1.32.3 using the update.ts script - should we bump this PR to the newer version? I'm currently running nix-build on an M2 MacBook Pro (aarch64-darwin)

[06kellyjac]

Rust on master still isnt 1.68 so we cant update past where we are ATM. It should reach master soonish though

[levex]

Gotcha - hopefully this gets resolved soon. I'm really keen on making sure Deno is up to date in nixpkgs.

[06kellyjac]

Reached master now
https://nixpk.gs/pr-tracker.html?pr=220373

rebased. added some other fixes, one of which will need testing on ofborg's darwin builders, if it doesn't work I'll revert it.

Not built it myself locally yet since my machine is pre-occupied and deno quite a while to build
https://hydra.nixos.org/job/nixpkgs/trunk/deno.x86_64-linux#tabs-charts

[06kellyjac]

@levex I see you've contributed to the deno project. Are you able to help me adapt the CVE POC to test my backport patch against older deno? #225898

[levex]

@06kellyjac Sure yes! Also Deno is updating today to 1.32.4 so maybe we are better off waiting on this PR until it's released within the next few hours.

[06kellyjac]

Thanks! I couldn't find the equivalent function in older deno diving through the docs.

For the update I don't mind either way. There's not much of a difference in effort for me merging & updating again & creating new PR, vs keeping the pr open & updating again & force pushing
:)

[levex]

Looks like there's a build failure

on c1a01a3ddafe8f5a070ada2abaf44757912cdeda
$ nix-build -E 'with import <nixpkgs> {}; callPackage pkgs/development/web/deno/default.nix {}'
[...snip...]
error: builder for '/nix/store/msc0bjzhjqxn2w887j6ryjgk7263a4hc-deno-1.32.3.drv' failed with exit code 101;
       last 10 log lines:
       >   --> ext/http/lib.rs:61:5
       >    |
       > 61 | use std::pin::pin;
       >    |     ^^^^^^^^^^^^^
       >    |
       >    = note: see issue #93178 <https://github.com/rust-lang/rust/issues/93178> for more information
       >
       > For more information about this error, try `rustc --explain E0658`.
       > error: could not compile `deno_http` due to 3 previous errors
       > warning: build failed, waiting for other jobs to finish...
       For full logs, run 'nix log /nix/store/msc0bjzhjqxn2w887j6ryjgk7263a4hc-deno-1.32.3.drv'.

aarch64-darwin M2 macbook pro

[06kellyjac]

Edit:
Ahh you're using your local <nixpkgs> to do the build which is providing old rust

You can do nix build github:06kellyjac/nixpkgs/deno#deno to make sure you get the whole working tree. (You may need to add unstable feature flags)

Or since it looks like you have cloned my branch you can do nix-build -A deno to just use the local ./. tree or nix-build -E 'with import ./. {}; callPackage pkgs/development/web/deno/default.nix {}' but I would recommend the former

---

This std::pin::pin issue should have been resolved by the upgrade to rust 1.68 🙃

https://blog.rust-lang.org/2023/03/09/Rust-1.68.0.html#local-pin-construction

🤔

[06kellyjac]

lld still not available in darwin builds as far as it seems, reverting for now

[aduh95]

The PR title and the commit message says deno 1.32.4, but the code says 1.32.3.

[06kellyjac]

staged but didn't get committed #226158