heroic: 2.6.2 -> 2.7.1 #229355
Merged
heroic: 2.6.2 -> 2.7.1 #229355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use stdenv.mkDerivation with fetchYarnDeps instead of mkYarnPackage to make the build process cleaner, and to not require vendoring any upstream source file. Also build for all upstream-supported platforms.
2.7.1 introduced a bug that caused the application to capture common keyboard shortcuts regardless of focus. There has been fixed upstream but not yet made it into a release.
openssl_1_1 is about to be marked insecure. As this is not a hard dependency of Heroic or Wine-GE, just drop it. Addresses NixOS#210452.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update Heroic Games Launcher to 2.7, and dependency
gogdlas required.The package now builds for all platforms supported by both upstream and nixpkgs, not just
x86_64-linux.Closes #225372
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)