ruby_3_0: make it use OpenSSL 3 #231899
Merged
ruby_3_0: make it use OpenSSL 3 #231899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaitoBezarius
force-pushed
the
please-no-openssl1-for-ruby-3
branch
from
b33aa36
to
bd3d081
Compare
|
@ofborg test gitlab |
RaitoBezarius
force-pushed
the
please-no-openssl1-for-ruby-3
branch
from
bd3d081
to
f4397f5
Compare
|
Staging retarget done. |
|
@ofborg build rubyPackages_3_0.nokogiri |
|
mastodon seems to be compatible with ruby_3_2: https://github.com/mastodon/mastodon/blob/main/.ruby-version |
marsam
reviewed
May 15, 2023
Ruby 3.0 pretend they don't support OpenSSL3 out of the box (https://bugs.ruby-lang.org/issues/18658). Actually, they suggest to install a OpenSSL 3.x gem. This is what we are doing. Our Ruby 3.0 will probably exhibit slight incompatibilities, in exchange, we get nice security.
RaitoBezarius
force-pushed
the
please-no-openssl1-for-ruby-3
branch
from
f4397f5
to
73df46e
Compare
|
@ofborg build ruby_2_7 |
That is only true for latest |
|
Just ran both integration tests for Mastodon on my machine ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Ruby 3.0 pretend they don't support OpenSSL3 out of the box (https://bugs.ruby-lang.org/issues/18658). Actually, they suggest to install a OpenSSL 3.x gem. This is what we are doing.
Our Ruby 3.0 will probably exhibit slight incompatibilities, in exchange, we get nice security.
cc #210452
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)