Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyprland-autoname-workspaces: init at 1.1.7 #236515

Merged

Conversation

donovanglover
Copy link
Member

Description of changes

Adds hyprland-autoname-workspaces

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@cyrinux
Copy link

cyrinux commented Jun 9, 2023

Thanks for the packaging ! Would be happy to have a PR for the README.md then. 🍰

@donovanglover donovanglover changed the title hyprland-autoname-workspaces: init at 1.0.0 hyprland-autoname-workspaces: init at 1.1.0 Jun 19, 2023
@cyrinux
Copy link

cyrinux commented Jun 19, 2023

Thanks!

@donovanglover donovanglover changed the title hyprland-autoname-workspaces: init at 1.1.0 hyprland-autoname-workspaces: init at 1.1.1 Jul 4, 2023
@donovanglover donovanglover changed the title hyprland-autoname-workspaces: init at 1.1.1 hyprland-autoname-workspaces: init at 1.1.3 Jul 8, 2023
@donovanglover donovanglover changed the title hyprland-autoname-workspaces: init at 1.1.3 hyprland-autoname-workspaces: init at 1.1.4 Jul 9, 2023
@donovanglover donovanglover changed the title hyprland-autoname-workspaces: init at 1.1.4 hyprland-autoname-workspaces: init at 1.1.5 Aug 7, 2023
@donovanglover
Copy link
Member Author

@cyrinux Just a heads up that I wasn't able to update to 1.1.7 due to the cargo dependencies. I'll try to get this merged soon since I think it got lost in the PRs

@donovanglover donovanglover changed the title hyprland-autoname-workspaces: init at 1.1.5 hyprland-autoname-workspaces: init at 1.1.7 Aug 7, 2023
@donovanglover
Copy link
Member Author

Nevermind, just saw the tag change so everything should be good now. 👍

@Janik-Haag
Copy link
Member

Result of nixpkgs-review pr 236515 run on x86_64-linux 1

1 package built:
  • hyprland-autoname-workspaces

Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just some nitpicks

@Janik-Haag Janik-Haag merged commit 7a1ae91 into NixOS:master Aug 7, 2023
8 of 9 checks passed
@donovanglover
Copy link
Member Author

Thanks!

@donovanglover donovanglover deleted the hyprland-autoname-workspaces branch August 2, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants