Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-swag: 1.8.12 -> 1.16.3 #257790

Merged
merged 1 commit into from
Mar 17, 2024
Merged

go-swag: 1.8.12 -> 1.16.3 #257790

merged 1 commit into from
Mar 17, 2024

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/swaggo/swag/releases.

meta.description for go-swag is: Automatically generate RESTful API documentation with Swagger 2.0 for Go

meta.homepage for go-swag is: https://github.com/swaggo/swag

Updates performed
  • Golang update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.16.2 with grep in /nix/store/cvhfhvgks8yfqqwzahm7dqjhjmddy44d-go-swag-1.16.2
  • found 1.16.2 in filename of file in /nix/store/cvhfhvgks8yfqqwzahm7dqjhjmddy44d-go-swag-1.16.2

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
go-swag
pufferpanel
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/cvhfhvgks8yfqqwzahm7dqjhjmddy44d-go-swag-1.16.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A go-swag https://github.com/r-ryantm/nixpkgs/archive/9f608acd572db8d99a21a04c90bb874c9c691b07.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/9f608acd572db8d99a21a04c90bb874c9c691b07#go-swag

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/cvhfhvgks8yfqqwzahm7dqjhjmddy44d-go-swag-1.16.2
ls -la /nix/store/cvhfhvgks8yfqqwzahm7dqjhjmddy44d-go-swag-1.16.2/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:
  • pufferpanel
1 package built:
  • go-swag

Maintainer pings

cc @StephenWithPH for testing.

@wegank
Copy link
Member

wegank commented Oct 13, 2023

@ofborg build pufferpanel

@wegank wegank marked this pull request as draft October 13, 2023 00:23
@r-ryantm r-ryantm changed the title go-swag: 1.8.12 -> 1.16.2 go-swag: 1.8.12 -> 1.16.3 Feb 2, 2024
@r-ryantm
Copy link
Contributor Author

r-ryantm commented Feb 2, 2024

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/swaggo/swag/releases.

meta.description for go-swag is: Automatically generate RESTful API documentation with Swagger 2.0 for Go

meta.homepage for go-swag is: https://github.com/swaggo/swag

Updates performed
  • Golang update
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.16.3 with grep in /nix/store/8fdvmzfsrfi5mxrd182ly5d2y9sa07j6-go-swag-1.16.3
  • found 1.16.3 in filename of file in /nix/store/8fdvmzfsrfi5mxrd182ly5d2y9sa07j6-go-swag-1.16.3

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
go-swag
pufferpanel
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/8fdvmzfsrfi5mxrd182ly5d2y9sa07j6-go-swag-1.16.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A go-swag https://github.com/r-ryantm/nixpkgs/archive/c3d97636e0e0f22650c0cb02dd2cb8a185a53dd5.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/c3d97636e0e0f22650c0cb02dd2cb8a185a53dd5#go-swag

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/8fdvmzfsrfi5mxrd182ly5d2y9sa07j6-go-swag-1.16.3
ls -la /nix/store/8fdvmzfsrfi5mxrd182ly5d2y9sa07j6-go-swag-1.16.3/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:
  • pufferpanel
1 package built:
  • go-swag

Maintainer pings

cc @StephenWithPH for testing.

Copy link
Contributor

@StephenWithPH StephenWithPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built the PR locally and ran the resulting bin successfully.

@StephenWithPH
Copy link
Contributor

@wegank ... I see you marked this as a draft. The PR looks good to me. I'm unclear on the breakage of pufferpanel.

@wegank
Copy link
Member

wegank commented Mar 16, 2024

@tie As the maintainer of pufferpanel, would you please have a look?

@tie
Copy link
Member

tie commented Mar 16, 2024

PufferPanel has outdated dependency, see also swaggo/swag#1568

I’ve opened #296527 that should fix this issue.

@tie tie mentioned this pull request Mar 17, 2024
13 tasks
@wegank wegank marked this pull request as ready for review March 17, 2024 18:53
@wegank
Copy link
Member

wegank commented Mar 17, 2024

@ofborg build pufferpanel pufferpanel.passthru.tests

@wegank wegank merged commit 48cb540 into NixOS:master Mar 17, 2024
27 of 29 checks passed
@r-ryantm r-ryantm deleted the auto-update/go-swag branch March 18, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants