pufferpanel: bump for go-swag update #296527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package fails to build with recent go-swag versions. We could have used `go run github.com/swaggo/swag/cmd/swag`, but with the current Go language framework in Nixpkgs this is really awkward since it’s hard to infer proper GOOS/GOARCH/etc environment variables for the build platform (and also reset environment variables intended for go build).
ofborg
bot
added
11.by: package-maintainer
ckiee
approved these changes
Mar 17, 2024
wegank
approved these changes
Mar 17, 2024
|
Seems not, tested both with and without that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The package fails to build with recent go-swag versions. We could have used
go run github.com/swaggo/swag/cmd/swag, but with the current Go language framework in Nixpkgs this is really awkward since it’s hard to infer proper GOOS/GOARCH/etc environment variables for the build platform (and also reset environment variables intended for go build).Note that resetting GOOS and GOARCH would not be enough, there are other variables that control an executable for that is build for
go runinvocation (e.g. GOARM).See #257790
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.