Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tor-browser: 12.5.5 -> 12.5.6 #258116

Merged
merged 1 commit into from
Sep 30, 2023
Merged

tor-browser: 12.5.5 -> 12.5.6 #258116

merged 1 commit into from
Sep 30, 2023

Conversation

panicgh
Copy link
Contributor

@panicgh panicgh commented Sep 29, 2023 •
edited

Description of changes

https://blog.torproject.org/new-release-tor-browser-1256/

Security update:

Fixes the VP8 encoder bug. #258048.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from hax404 and joachifm September 30, 2023 00:01
@felschr
Copy link
Member

felschr commented Sep 30, 2023

Result of nixpkgs-review pr 258116 run on x86_64-linux 1

1 package built:
  • tor-browser

felschr
felschr approved these changes Sep 30, 2023
View reviewed changes
Copy link
Member

@felschr felschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felschr
Copy link
Member

felschr commented Sep 30, 2023 •
edited

@panicgh Btw, I've just noticed that Mullvad Browser 12.5.6 is also already available on torproject.org:
https://dist.torproject.org/mullvadbrowser/
https://archive.torproject.org/tor-package-archive/mullvadbrowser/12.5.6/

I've added those & some other mirrors to the list of urls in #256935.

If they keep publishing Tor Browser & Mullvad Browser releases on those pages simultaneously, we could even update them in a single PR in the future.

@felschr felschr mentioned this pull request Sep 30, 2023
Merged
12 tasks
@mweinelt mweinelt merged commit 59c816e into NixOS:master Sep 30, 2023
31 checks passed
@github-actions github-actions bot mentioned this pull request Sep 30, 2023
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.05:

@felschr felschr mentioned this pull request Sep 30, 2023
Open
65 tasks
@panicgh panicgh deleted the tbb branch September 30, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felschr felschr felschr approved these changes

@hax404 hax404 Awaiting requested review from hax404

@joachifm joachifm Awaiting requested review from joachifm

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12.approvals: 1 12.approved-by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@panicgh @felschr @mweinelt