New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: migrate doc comments #262987
Draft
hsjobeki
wants to merge
1
commit into
NixOS:master
Choose a base branch
from
hsjobeki:migrate-doc-comments
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
treewide: migrate doc comments #262987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
6.topic: nixos
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: haskell
6.topic: qt/kde
8.has: module (update)
6.topic: emacs
6.topic: printing
6.topic: rust
6.topic: ruby
6.topic: vim
6.topic: erlang
6.topic: ocaml
6.topic: fetch
6.topic: stdenv
Standard environment
6.topic: TeX
Issues regarding texlive and TeX in general
6.topic: lua
6.topic: cinnamon
6.topic: module system
About NixOS module system internals
6.topic: systemd
6.topic: agda
6.topic: vscode
6.topic: lib
The Nixpkgs function library
labels
Oct 23, 2023
hsjobeki
force-pushed
the
migrate-doc-comments
branch
from
October 23, 2023 18:43
b5cbee6
to
c031ca7
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
Oct 23, 2023
hsjobeki
force-pushed
the
migrate-doc-comments
branch
from
November 13, 2023 14:10
c031ca7
to
047dce5
Compare
github-actions
bot
force-pushed
the
migrate-doc-comments
branch
4 times, most recently
from
March 26, 2024 01:08
fd2586d
to
e0c7b34
Compare
github-actions
bot
force-pushed
the
migrate-doc-comments
branch
from
March 30, 2024 01:06
e0c7b34
to
5b1384f
Compare
ofborg
bot
added
10.rebuild-darwin: 0
and removed
10.rebuild-darwin: 1
10.rebuild-darwin: 1-10
labels
Mar 30, 2024
13 tasks
github-actions
bot
force-pushed
the
migrate-doc-comments
branch
3 times, most recently
from
April 2, 2024 01:11
43caf19
to
358c247
Compare
github-actions
bot
force-pushed
the
migrate-doc-comments
branch
from
April 11, 2024 08:32
358c247
to
cc89e32
Compare
github-actions
bot
force-pushed
the
migrate-doc-comments
branch
7 times, most recently
from
April 20, 2024 01:11
c86eb3c
to
ede593a
Compare
github-actions
bot
force-pushed
the
migrate-doc-comments
branch
2 times, most recently
from
April 30, 2024 01:03
78e0dbb
to
61f973c
Compare
github-actions
bot
force-pushed
the
migrate-doc-comments
branch
from
May 1, 2024 01:08
61f973c
to
e05057e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.status: merge conflict
6.topic: agda
6.topic: cinnamon
6.topic: emacs
6.topic: erlang
6.topic: fetch
6.topic: flakes
The experimental Nix feature
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: haskell
6.topic: lib
The Nixpkgs function library
6.topic: lua
6.topic: module system
About NixOS module system internals
6.topic: nixos
6.topic: ocaml
6.topic: php
6.topic: printing
6.topic: python
6.topic: qt/kde
6.topic: ruby
6.topic: rust
6.topic: stdenv
Standard environment
6.topic: systemd
6.topic: TeX
Issues regarding texlive and TeX in general
6.topic: vim
6.topic: vscode
8.has: module (update)
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready to be merged yet.
Description of changes
Reformat doc-comments according to RFC145.
/**
and ends with the regular*/
2
(No hitting whitespace anymore yay!)Some handwork is still needed.
This PR is automatically updated every day.
demo of the rendered comments: https://noogle.dev
This breaks compatibility with the existing manual. (Migrations ongoing)
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)