masterpdfeditor: init at 4.2.70 #27790

CMCDragonkai · 2017-07-31T06:54:29Z

Motivation for this change

Added masterpdfeditor.

This is the best PDF editor available on Linux. I've tried them all but only this one allows me to add text into unfillable forms.

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

I had some code here for 32 bit, but since I don't have a 32 bit machine I can't test the build of it. What's the right way to specify that this package is only for 64 bit?

I tested this on nix-shell, but not part of main nixpkgs.

FRidh

See Spotify e.g. on how to specify the derivation is available only for one arch.
do test build with nix-build -A masterpdeditor. nix-shell sets some additional env vars so it is not entirely the same.
update the commit title according to the guidelines

FRidh · 2017-07-31T07:20:29Z

pkgs/applications/misc/masterpdfeditor/default.nix

+    url = {
+      "x86_64-linux" = "http://get.code-industry.net/public/master-pdf-editor-${version}_qt5.amd64.tar.gz";
+    }."${stdenv.system}";
+    sha1 = {


sha1 is no longer considered secure. Use sha256 or above.

FRidh · 2017-07-31T07:21:06Z

pkgs/applications/misc/masterpdfeditor/default.nix

+      name = "masterpdfeditor-${version}";
+      src = fetchurl {
+        url = url;
+        sha1 = sha1;


inherit both

FRidh · 2017-07-31T07:22:09Z

pkgs/top-level/all-packages.nix

@@ -13290,6 +13290,11 @@ with pkgs;

  adobe-reader = callPackage_i686 ../applications/misc/adobe-reader { };

+  masterpdfeditor = callPackage ../applications/misc/masterpdfeditor {


I think you're supposed to use libsForQt5.callPackage

Ok that fills in the qtbase and qtsvg dependencies, but something is still broken with xcb. It didn't happen with nix-shell.

FRidh · 2017-07-31T07:24:21Z

pkgs/applications/misc/masterpdfeditor/default.nix

+  let
+    version = "4.2.70";
+    url = {
+      "x86_64-linux" = "http://get.code-industry.net/public/master-pdf-editor-${version}_qt5.amd64.tar.gz";


get rid of the set if you only support one arch

Decided to leave it out, since I can't test whether the 32 bit build works.

CMCDragonkai · 2017-07-31T07:39:09Z

I'm getting errors like this now:

This application failed to start because it could not find or load the Qt platform plugin "xcb"
in "".

Reinstalling the application may fix this problem.
zsh: abort      masterpdfeditor4

This didn't happen inside nix-shell.

CMCDragonkai · 2017-07-31T07:48:31Z

Ok looks like I might need libQt5DBus.so.5 or libqxcb.so

CMCDragonkai · 2017-07-31T07:55:10Z

@FRidh So I did build it with nix-build. But with a slightly different default.nix file. And this worked without the above error.

{ pkgs ? import <nixpkgs> {} }:
  with pkgs;
  let
    version = "4.2.70";
    url = {
      "i686-linux" = "http://get.code-industry.net/public/master-pdf-editor-${version}_i386.tar.gz";
      "x86_64-linux" = "http://get.code-industry.net/public/master-pdf-editor-${version}_qt5.amd64.tar.gz";
    }."${stdenv.system}";
    sha1 = {
      "i686-linux" = "bfd8af8d68f52619504c83ea23e4dbe962a386d8";
      "x86_64-linux" = "1c7ffc8858ef5034d6f29f4ee783bc8fb4478fb5";
    }."${stdenv.system}";
    libs = {
      "i686-linux" = [
        stdenv.cc.cc
        glibc
        sane-backends
        qt4
        xorg.libXext
        xorg.libX11
        xorg.libXdmcp
        xorg.libXau
        xorg.libxcb
      ];
      "x86_64-linux" = [
        stdenv.cc.cc
        glibc
        sane-backends
        qt5.qtbase
        qt5.qtsvg
        xorg.libXext
        xorg.libX11
        xorg.libXdmcp
        xorg.libXau
        xorg.libxcb
      ];
    }."${stdenv.system}";
  in
    stdenv.mkDerivation {
      name = "masterpdfeditor-${version}";
      src = fetchurl {
        url = url;
        sha1 = sha1;
      };
      libPath = stdenv.lib.makeLibraryPath libs;
      dontStrip = true;
      installPhase = ''
        mkdir -pv $out/bin
        cp -v masterpdfeditor4 $out/bin/masterpdfeditor4
        cp -v masterpdfeditor4.png $out/bin/masterpdfeditor4.png
        cp -v -r stamps $out/bin/stamps
        cp -v -r templates $out/bin/templates
        cp -v -r lang $out/bin/lang
        cp -v -r fonts $out/bin/fonts
        patchelf --interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" \
                 --set-rpath $libPath \
                 $out/bin/masterpdfeditor4
      '';
      meta = {
        description = "Master PDF Editor";
        homepage = "https://code-industry.net/free-pdf-editor/";
        license = stdenv.lib.licenses.unfreeRedistributable;
        platforms = stdenv.lib.platforms.linux;
        maintainers = stdenv.lib.maintainers.cmcdragonkai;
      };
    }

CMCDragonkai · 2017-07-31T08:05:21Z

#15498

CMCDragonkai · 2017-07-31T08:05:50Z

#24256
#16255

CMCDragonkai · 2017-07-31T08:17:33Z

According to those issues, this may not be an issue with the nix expression I wrote, but something to do with the way nixos/nixpkgs organises its qt plugins. And I'm not sure how to invocate masterpdfeditor4 with the correct qt plugins. It appears there was a fix in master to solve this somehow, but I've got a filled QT_PLUGIN_PATH env variable pointing mostly to qt4 plugins, not qt5.

FRidh · 2017-08-01T16:31:16Z

@CMCDragonkai Qt applications cannot be run from the store anymore, but need to be installed to a profile or ran from a nix-shell. Testing it from a profile (e.g. nix-env -iA masterpdfeditor) is the right approach. I quickly installed and ran it.

CMCDragonkai · 2017-08-01T16:36:16Z

So this expression worked for you? I don't understand what you mean by not being able to run qt applications from the nix store.

…

On 2 Aug 2017 2:31 AM, "Frederik Rietdijk" ***@***.***> wrote: @CMCDragonkai <https://github.com/cmcdragonkai> Qt applications cannot be run from the store anymore, but need to be installed to a profile or ran from a nix-shell. Testing it from a profile (e.g. nix-env -iA masterpdfeditor) is the right approach. I quickly installed and ran it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#27790 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAnHHR0QT689U9WCFtYoYIryKWGPcyQgks5sT1LYgaJpZM4On-Ey> .

FRidh · 2017-08-01T16:40:56Z

I meant the following doesn't work:

$(nix-build -A masterpdfeditor)/bin/masterpdfeditor4

whereas

$ nix-env -iA masterpdfeditor -f . && masterpdfeditor4

should.

Note that running it from the store did work for me, but I suppose that's because I have a Plasma desktop with the same version of Qt.

FRidh · 2017-08-01T16:42:07Z

The underlying issue is, if I am correct, that Qt now uses propagatedUserEnvPkgs, therefore depending on packages in your profile.

CMCDragonkai · 2017-08-02T02:58:17Z

I had the exact opposite experience to yours. My nix-build works for masterpdfeditor4, but my nix-env doesn't properly install masterpdfeditor, possibly due to the links I posted above something to do with impurity in QT applications currently.

…

On 08/02/2017 02:41 AM, Frederik Rietdijk wrote: I meant the following doesn't work: |$(nix-build -A masterpdfeditor)/bin/masterpdfeditor4 | whereas |$ nix-env -iA masterpdfeditor -f . && masterpdfeditor4 | should. Note that running it from the store did work for me, but I suppose that's because I have a Plasma desktop with the same version of Qt. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#27790 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAnHHZ-mpNNPsLgMgIQcyV4aQUmmn89kks5sT1UcgaJpZM4On-Ey>.

CMCDragonkai · 2017-08-12T09:14:04Z

Can anybody who has more experience with QT apps review this?

flokli · 2017-10-16T10:12:29Z

@CMCDragonkai, @FRidh: I rebased this on latest master and tried executing, both using nix-shell and directly from the nix store. In both cases, it complained like this:

# nix-shell -p masterpdfeditor -I nixpkgs=$PWD --run "masterpdfeditor4"
This application failed to start because it could not find or load the Qt platform plugin "xcb"
in "".

Reinstalling the application may fix this problem.
/run/user/1000/nix-shell.zggzXe/rc: line 1: 29223 Aborted                 masterpdfeditor4

Did anything change by now in how QT applications should be wrapped?

CMCDragonkai · 2017-10-16T12:11:11Z

It did work inside a nix shell before. But I'm not sure about how Qt apps are meant to work.

EDIT: Qt apps are very side-effectful relying on some sort of plugin integration. So whether it works in nix-build, nix-env or nix-shell depends alot on the environment...

also add flokli as maintainer

flokli · 2017-11-01T21:27:57Z

As described by @ttuegel in #30977, Qt applications currently don't seem to work when being run from nix-shell without a QT user environment in place, so that could have been my issue.

After having some dependent qt applications in my user environment, I was able to execute masterpdfeditor by $(nix-build -A masterpdfeditor)/bin/masterpdfeditor4, and also when adding it to my home environment (without the other qt application being pulled in).

I bumped to the latest version 4.3.61, and added myself as maintainer. Also patched and added the .desktop file from there.

@CMCDragonkai could you give my masterpdfeditor branch a try and if good push into this PR?

CMCDragonkai · 2017-11-02T04:27:29Z

Your changes look good. The masterpdfeditor here does work on my machine, just not inside nix-shell, and only after I ran nix-build. So it looks like we kind of know what the problem is. Is there a way that you can push your changes into this PR? Or how would I pull in your changes into this PR into a combined PR?

CMCDragonkai · 2017-11-02T05:33:01Z

I think I can pull in your branch and merge it into this PR.

CMCDragonkai · 2017-11-02T05:39:32Z

@flokli Oh I can't do that, because you didn't fork from this PR, so I cannot cleanly merge your changes into this PR's branch. Instead your branch contains everything, so you should submit a PR and this PR can be closed in favour of yours.

orivej · 2017-11-02T05:43:43Z

@CMCDragonkai If you agree with his changes, git reset --hard his-branch and git push --force it.

CMCDragonkai · 2017-11-02T05:43:49Z

@flokli I just tried your branch installing masterpdfeditor from there, the build worked, but running the program results in:

Cannot mix incompatible Qt library (version 0x50901) with this library (version 0x50902)
zsh: abort      masterpdfeditor4

Looks like it requires some update to Qt. My current system nixpkgs commit is 8fefa85 while your branch is later.

There's still side-effects in this Qt package that won't work unless some other environment stuff is set.

This problem exists in other Qt packages as well: #30551

So I don't think the above problem should prevent this package from being accepted. This is a global problem for all qt packages in NixOS.

CMCDragonkai · 2017-11-02T05:48:29Z

@orivej Thanks for the tip. I did that now.

@flokli No need for extra PR. This PR is now updated with your branch.

orivej · 2017-11-02T06:14:32Z

It is great for PDF forms indeed. However, stamps/, templates/ etc. should go to $out/opt/masterpdfeditor/, not to $out/bin/. (For example, this is where dropbox and vagrant go.) Then $out/opt/masterpdfeditor/masterpdfeditor4 should be symlinked into $out/bin/.

…rom $out/bin

flokli · 2017-11-02T09:54:05Z

@orivej I already tried if it could be made to load assets from $out/share/$pname, but seems it has to come from next to the binary.

I moved everything and added the symlink as suggested.

orivej

That's perfect, thank you!

CMCDragonkai · 2017-11-04T10:15:45Z

Hey is this going to be pulled in?

CMCDragonkai force-pushed the masterpdfeditor branch 2 times, most recently from 85faa03 to 5bcd537 Compare July 31, 2017 07:17

FRidh requested changes Jul 31, 2017

View reviewed changes

FRidh added the 8.has: package (new) label Jul 31, 2017

CMCDragonkai force-pushed the masterpdfeditor branch 2 times, most recently from 1f029ae to c5aa656 Compare July 31, 2017 07:37

CMCDragonkai changed the title ~~masterpdfeditor: Added masterpdfeditor~~ masterpdfeditor: init at 4.2.70 Jul 31, 2017

FRidh added the 6.topic: qt/kde label Jul 31, 2017

CMCDragonkai mentioned this pull request Jul 31, 2017

Qt applications fail due to xcb plugin mismatch #24256

Closed

CMCDragonkai and others added 3 commits November 1, 2017 21:14

masterpdfeditor: init at 4.2.70

8e541c0

masterpdfeditor: 4.2.70 -> 4.3.61

fbf1126

also add flokli as maintainer

masterpdfeditor: add .desktop file and LICENSE

8162e58

masterpdfeditor: fix platform (amd64 only)

e4913c2

CMCDragonkai force-pushed the masterpdfeditor branch from c5aa656 to e4913c2 Compare November 2, 2017 05:47

CMCDragonkai requested a review from nbp as a code owner November 2, 2017 05:47

CMCDragonkai mentioned this pull request Nov 2, 2017

Mixing incompatible Qt library (version 0x50902) with this library (version 0x50901) #30551

Closed

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Nov 2, 2017

masterpdfeditor: move assets into $out/opt/masterpdfeditor, symlink f…

faa9afb

…rom $out/bin

orivej approved these changes Nov 2, 2017

View reviewed changes

orivej merged commit 86415c9 into NixOS:master Nov 4, 2017

CMCDragonkai deleted the masterpdfeditor branch August 8, 2018 11:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

masterpdfeditor: init at 4.2.70 #27790

masterpdfeditor: init at 4.2.70 #27790

CMCDragonkai commented Jul 31, 2017 •

edited

Loading

FRidh left a comment

FRidh Jul 31, 2017

FRidh Jul 31, 2017

FRidh Jul 31, 2017

CMCDragonkai Jul 31, 2017

FRidh Jul 31, 2017

CMCDragonkai Jul 31, 2017

CMCDragonkai commented Jul 31, 2017

CMCDragonkai commented Jul 31, 2017

CMCDragonkai commented Jul 31, 2017

CMCDragonkai commented Jul 31, 2017

CMCDragonkai commented Jul 31, 2017 •

edited

Loading

CMCDragonkai commented Jul 31, 2017

FRidh commented Aug 1, 2017

CMCDragonkai commented Aug 1, 2017 via email

FRidh commented Aug 1, 2017

FRidh commented Aug 1, 2017

CMCDragonkai commented Aug 2, 2017 via email

CMCDragonkai commented Aug 12, 2017

flokli commented Oct 16, 2017

CMCDragonkai commented Oct 16, 2017 •

edited

Loading

flokli commented Nov 1, 2017

CMCDragonkai commented Nov 2, 2017

CMCDragonkai commented Nov 2, 2017

CMCDragonkai commented Nov 2, 2017

orivej commented Nov 2, 2017

CMCDragonkai commented Nov 2, 2017 •

edited

Loading

CMCDragonkai commented Nov 2, 2017 •

edited

Loading

orivej commented Nov 2, 2017

flokli commented Nov 2, 2017 •

edited

Loading

orivej left a comment

CMCDragonkai commented Nov 4, 2017

		@@ -13290,6 +13290,11 @@ with pkgs;

		adobe-reader = callPackage_i686 ../applications/misc/adobe-reader { };

		masterpdfeditor = callPackage ../applications/misc/masterpdfeditor {

masterpdfeditor: init at 4.2.70 #27790

masterpdfeditor: init at 4.2.70 #27790

Conversation

CMCDragonkai commented Jul 31, 2017 • edited Loading

Motivation for this change

Things done

FRidh left a comment

Choose a reason for hiding this comment

FRidh Jul 31, 2017

Choose a reason for hiding this comment

FRidh Jul 31, 2017

Choose a reason for hiding this comment

FRidh Jul 31, 2017

Choose a reason for hiding this comment

CMCDragonkai Jul 31, 2017

Choose a reason for hiding this comment

FRidh Jul 31, 2017

Choose a reason for hiding this comment

CMCDragonkai Jul 31, 2017

Choose a reason for hiding this comment

CMCDragonkai commented Jul 31, 2017

CMCDragonkai commented Jul 31, 2017

CMCDragonkai commented Jul 31, 2017

CMCDragonkai commented Jul 31, 2017

CMCDragonkai commented Jul 31, 2017 • edited Loading

CMCDragonkai commented Jul 31, 2017

FRidh commented Aug 1, 2017

CMCDragonkai commented Aug 1, 2017 via email

FRidh commented Aug 1, 2017

FRidh commented Aug 1, 2017

CMCDragonkai commented Aug 2, 2017 via email

CMCDragonkai commented Aug 12, 2017

flokli commented Oct 16, 2017

CMCDragonkai commented Oct 16, 2017 • edited Loading

flokli commented Nov 1, 2017

CMCDragonkai commented Nov 2, 2017

CMCDragonkai commented Nov 2, 2017

CMCDragonkai commented Nov 2, 2017

orivej commented Nov 2, 2017

CMCDragonkai commented Nov 2, 2017 • edited Loading

CMCDragonkai commented Nov 2, 2017 • edited Loading

orivej commented Nov 2, 2017

flokli commented Nov 2, 2017 • edited Loading

orivej left a comment

Choose a reason for hiding this comment

CMCDragonkai commented Nov 4, 2017

CMCDragonkai commented Jul 31, 2017 •

edited

Loading

CMCDragonkai commented Jul 31, 2017 •

edited

Loading

CMCDragonkai commented Oct 16, 2017 •

edited

Loading

CMCDragonkai commented Nov 2, 2017 •

edited

Loading

CMCDragonkai commented Nov 2, 2017 •

edited

Loading

flokli commented Nov 2, 2017 •

edited

Loading