-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvm: 4.0.1 -> 5.0.0rc2 #28410
llvm: 4.0.1 -> 5.0.0rc2 #28410
Conversation
The source hashes are wrong. EDIT: well, not for llvm package itself... |
It seems you copied the files from some older nixpkgs version and therefore missed changes, e.g. around man pages in llvm. (Copying is prone to this, unfortunately.) |
Hmm, llvm tests now try stuff with suid/sgid permission bits and thus fail when sandboxed :-/ |
This is what I've been using to disable those tests on 5+, basically nuke the entire Path unittest. A better approach would be to patch out the failing tests, but thought I'd share anyway in case it's useful: # FileSystem permissions tests fail with various special bits
substituteInPlace llvm/unittests/Support/CMakeLists.txt \
--replace "Path.cpp" ""
rm llvm/unittests/Support/Path.cpp |
Alright here's where I'm at:
with import <nixpkgs> {}; {
tmpAoeu = stdenv.mkDerivation {
name = "tmpAoeu";
hardeningDisable = [ "all" ];
buildInputs = [
cmake
llvmPackages_5.clang-unwrapped
llvm_5
lld
];
};
} |
Here are the rc3 hashes: andrewrk@f18e59c |
This seems dead, probably should be closed in favor of #29541 . |
Motivation for this change
LLVM 5.0 is coming out soon. From llvm.org, final release is August 23. This is rc2, we can test and see if everything works. I think we should be able to drop it in place instead of llvm 4, nothing really big changed.
I'm still waiting for it to build, will update this PR when status changes.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)