Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.{osqp,cvxpy,jaxopt,qutip}: scipy 1.12 fixes #286237

Merged
4 commits merged into from Feb 6, 2024
Merged

python311Packages.{osqp,cvxpy,jaxopt,qutip}: scipy 1.12 fixes #286237

4 commits merged into from Feb 6, 2024

Conversation

ghost
Copy link

@ghost ghost commented Feb 4, 2024

Description of changes

closes #284308
various fixes for scipy 1.12 update:

scikit-survival is failing due to an unrelated error sksurv/tree/_criterion.pyx:16:0: 'sklearn/tree/_tree/DOUBLE_t.pxd' not found

Result of nixpkgs-review run on x86_64-linux 1

2 packages failed to build:
  • python311Packages.scikit-survival
  • python311Packages.scikit-survival.dist
14 packages built:
  • python311Packages.bambi
  • python311Packages.bambi.dist
  • python311Packages.blackjax
  • python311Packages.blackjax.dist
  • python311Packages.cvxpy
  • python311Packages.cvxpy.dist
  • python311Packages.jaxopt
  • python311Packages.jaxopt.dist
  • python311Packages.osqp
  • python311Packages.osqp.dist
  • python311Packages.qpsolvers
  • python311Packages.qpsolvers.dist
  • python311Packages.qutip
  • python311Packages.qutip.dist

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

disable unit tests failing after upgrade to scipy 1.12 as they appear to
just be issues with the test and not the underlying functionality. Can
re-enable once osqp/osqp-python#121 is closed.
@ofborg ofborg bot requested a review from drewrisinger February 4, 2024 08:46
@ghost ghost marked this pull request as draft February 4, 2024 14:12
@ghost ghost changed the title python311Packages.{osqp,cvxpy}: disable failing unit tests python311Packages.{osqp,cvxpy,jaxopt,qutip}: scipy 1.12 fixes Feb 4, 2024
@ofborg ofborg bot requested review from bcdarwin and FabianGD February 4, 2024 14:35
@ghost ghost marked this pull request as ready for review February 4, 2024 14:35
@ghost ghost marked this pull request as draft February 4, 2024 19:28
@ghost
Copy link
Author

ghost commented Feb 4, 2024

annalee added 2 commits February 4, 2024 22:07
fixes unit test failure after scipy 1.12 upgrade
…cipy 1.12 update

add patch and disable failing aarch64 linux tests
@ghost ghost marked this pull request as ready for review February 5, 2024 00:31
@ghost ghost requested a review from GaetanLepage February 5, 2024 00:33
@ghost ghost merged commit 77d6035 into NixOS:master Feb 6, 2024
22 of 23 checks passed
@ghost ghost deleted the scipy-1.12-osqp-unittests branch February 6, 2024 04:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failures: python3Packages.{osqp,cvxpy,jaxopt,qutip,scs} after scipy 1.12 update
0 participants