modrinth-app: init at 0.7.1

[getchoo]

Description of changes

the modrinth app is a unique, open source minecraft launcher that allows you to play your favorite mods, and keep them up to date, all in one neat little package

it is marked as unfreeRedistributable due to the assets being used. it can also compile on aarch64, however the launcher itself doesn't support it yet

fixes #247468

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[getchoo]

almost forgot: i'm not really sure how we are meant to handle wrappers (a la prismlauncher) in the new by-name scheme. let me know if my guess was wrong :p

[Alanazane]

Thanks for doing this!
Manually tested and was successfully able to install mods/launch Minecraft 🎉

Result of nixpkgs-review pr 289149 run on x86_64-linux 1

2 packages built:

• modrinth-app
• modrinth-app-unwrapped

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3654

[quantenzitrone]

code looks good; ofborg is happy; Alanazane can successfully play Minecraft with it 👍

[getchoo]

fixed building on darwin

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3881

[Scrumplex]

When rebased onto master, this fails to build because of #307077

[getchoo]

When rebased onto master, this fails to build because of #307077

thanks for catching this :)