wrapGAppsHook3: rename from wrapGAppsHook #307077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
requested review from
mkg20001,
figsoda,
adisbladis,
K900,
NickCao,
SuperSandro2000,
ttuegel,
mweinelt,
sternenseemann,
maralorn,
ncfavier,
infinisil and
Ericson2314
as code owners
github-actions
bot
added
6.topic: python
6.topic: nixos
6.topic: GNOME
amaxine
approved these changes
Apr 26, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This was achieved using the following command:
sd 'wrapGAppsHook\b' wrapGAppsHook3 (rg -l 'wrapGAppsHook\b')
And then manually reverted the following changes:
- alias in top-level.nix
- function name in wrap-gapps-hook.sh
- comment in postFixup of at-spi2-core
- comment in gtk4
- comment in preFixup of 1password-gui/linux.nix
- comment in postFixup of qgis/unwrapped-ltr.nix and qgis/unwrapped.nix
- comment in postFixup of telegram-desktop
- comment in postFixup of fwupd
- buildCommand of mongodb-compass
- postFixup of xflux-gui
- comment in a patch in kdePackages.kde-gtk-config and plasma5Packages.kde-gtk-config
- description of programs.sway.wrapperFeatures.gtk NixOS option (manual rebuild)
Now that there are no references in Nixpkgs.
wegank
approved these changes
Apr 27, 2024
|
A bit of fallout:
|
|
New PR due to accidental mass ping: #307845 |
13 tasks
13 tasks
imincik
added a commit
to imincik/geospatial-nix
that referenced
this pull request
May 9, 2024
imincik
added a commit
to imincik/geospatial-nix
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
GTK 3 is slowly approaching deprecation so let’s not make it default.
Closes #303921.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.