Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matchbox-server package #298689

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Add matchbox-server package #298689

merged 2 commits into from
Mar 26, 2024

Conversation

dghubble
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Add a Nix `matchbox-server` package for the matchbox project
https://github.com/poseidon/matchbox. It provides a server for
PXE booting and provisioning machines into clusters and has been
maintained for many years

Note: A matchbox-window-manager is already using the Nix package name
matchbox, so name this new package matchbox-server
@RaitoBezarius
Copy link
Member

Result of nixpkgs-review pr 298689 run on x86_64-linux 1

1 package built:
  • matchbox-server

Copy link
Member

@RaitoBezarius RaitoBezarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your first time contribution, for the next time, if you could write a small description of the package added, that'd be great to give some context to the reviewer. :)

@RaitoBezarius RaitoBezarius merged commit 7563771 into NixOS:master Mar 26, 2024
31 checks passed
@RaitoBezarius
Copy link
Member

Result of nixpkgs-review pr 298689 run on aarch64-darwin 1

1 package failed to build:
  • matchbox-server

@RaitoBezarius
Copy link
Member

Result of nixpkgs-review pr 298689 run on x86_64-darwin 1

1 package failed to build:
  • matchbox-server

@dghubble
Copy link
Member Author

I can nix-build -A matchbox-server on darwin successfully, so I wonder if those build failures you posted are because they ran after the merge or if they have logs I can see

@RaitoBezarius
Copy link
Member

RaitoBezarius commented Mar 26, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants