kodiPackages.sendtokodi: remove dependency on youtube_dl #327480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sendtokodi plugin for Kodi can use both yt-dlp and youtube_dl to play back various URLs. Both of these packages have been susceptible to CVE-2024-38519. But while yt-dlp is still maintained and was patched, youtube_dl is unmaintained and thus known-vulnerable. Patch out the dependency on youtube_dl so that sendtokodi will only ever use yt-dlp to resolve URLs.
ofborg
bot
requested review from
dschrempf,
edwtjo,
sephalon,
nvmd,
cpages,
aanderse,
minijackson and
peterhoeg
1 task
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The sendtokodi plugin for Kodi can use both yt-dlp and youtube_dl to play back various URLs. Both of these packages have been susceptible to CVE-2024-38519. But while yt-dlp is still maintained and was patched, youtube_dl is unmaintained and thus known-vulnerable.
Patch out the dependency on youtube_dl so that sendtokodi will only ever use yt-dlp to resolve URLs.
Closes #326548.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Note that this only fixes one recent issue with the sendtokodi plugin. To make it fully working, #327479 needs to be merged as well since it transitively depends on inputstreamhelper.
Add a 👍 reaction to pull requests you find important.