Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kodiPackages.inputstreamhelper: fix compatibility with Python 3.12 #327479

Merged

Conversation

pks-t
Copy link
Contributor

@pks-t pks-t commented Jul 15, 2024

Description of changes

The inputstreamhelper Kodi script depends on the "distutils" package, which has been removed with Python 3.12. This has since been fixed upstream, but wasn't yet released. Backport the patch.

See emilsvennesson/script.module.inputstreamhelper#550 upstream.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

The inputstreamhelper Kodi script depends on the "distutils" package,
which has been removed with Python 3.12. This has since been fixed
upstream, but wasn't yet released. Backport the patch.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 15, 2024
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@aanderse aanderse merged commit 5276974 into NixOS:master Jul 16, 2024
26 of 28 checks passed
@pks-t pks-t deleted the pks-kodi-inputstreamhelper-fix-python-3-12-compat branch July 17, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants