neovim-unwrapped: Fix 'disallowedRequisites' error

[Gerg-L]

Description of changes

Tested on nix 2.24pre and nixVersions.minimum (2.3.18)

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[Gerg-L]

Not sure this is the correct answer, i can't get this build to fail with CA derivations which was the original reason for the postInstall patch at all

[Gerg-L]

it looks like the disallowedRequisites came from 9305ed3
But with removing the disallowedRequisites and the postInstall
it builds fine with nix-build --arg config '{ contentAddressedByDefault = true; }' -A neovim-unwrapped
CC: @tie you added these bits originally can you look at this?

[tie]

CC: @tie you added these bits originally can you look at this?

👀

I'll try to take a look at this tomorrow.

We should probably keep removeReferences though since IIRC neovim embeds the path to the compiler used to build it (e.g. you can verify this with nix-tree).

[Gerg-L]

alright if that's the case eedc7c0 should work, i'm not sure on the exact correct nix version i believe it's 2.18 that outputChecks.<output>.disallowedReferences was added but i'm not entirely sure

[tie]

Maybe we can set __structuredAttrs = true and outputChecks unconditionally (without disallowedRequisites and version checks)? 🤔
I assume this should work as expected for recent Nix versions that support structured attributes and be no-op otherwise.

Converting {,dis}allowed{References,Requisites} to outputChecks based on the the Nix version should probably be done in mkDerivation and not on per-package basis. Or ideally shouldn't be done at all, I'm not really a fan of discarding string context in these attributes as is currently implemented since it breaks with CA derivations, hence the PR you've mentioned—and removeReferences/nukeReferences should be enough to avoid unwanted references in the derivation outputs.

[Gerg-L]

your suggested solution works on

• 2.3
• 2.18
• 2.24-pre
• 2.24-pre CA

[Aleksanaa]

Sorry

[tie]

Apparently a similar fix was merged in #334915 (cc @Ma27). Is it OK to close this PR?