neovim-unwrapped: use outputChecks

[Ma27]

Description of changes

disallowedRequisites and friends will be ignored if __structuredAttrs is used. In Nix versions <2.24 and Lix <2.91 this happens silently, in newer versions a warning is printed.

The solution is to use outputChecks.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[teto]

Thanks for the heads up. I will trust you on this, just it would probably be best to target staging

[Ma27]

I will trust you on this

See also the warning section at https://nix.dev/manual/nix/2.24/language/advanced-attributes#adv-attr-structuredAttrs

just it would probably be best to target staging

I don't think that's necessary: it's mostly vimplugins being rebuilt.

[teto]

See also the warning section at https://nix.dev/manual/nix/2.24/language/advanced-attributes#adv-attr-structuredAttrs

thanks for the pointer pretty cool !

I don't think that's necessary: it's mostly vimplugins being rebuilt.

I used to think like that but I thin the sheer number of jobs is already a problem to scheduling. And the darwin builder is already slow enough as it is. This PR is not critical, it's not a problem to wait for it I think

[Ma27]

@teto done.