New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluez: add support for the sixaxis controller #51895

Merged
merged 1 commit into from Dec 15, 2018

Conversation

Projects
None yet
3 participants
@cdepillabout
Copy link
Contributor

cdepillabout commented Dec 12, 2018

This should add support for the Playstation Dualshock 3 and DualShock 4
controllers.

Motivation for this change

Currently the bluez package does not enable the sixaxis plugin. This sixaxis plugin is needed to support the Playstation Dualshock 3 and DualShock 4 controllers.

This can be easily compiled with the following command if you have this branch checked out:

nix-build -E 'with import ./. { }; bluez.override { enableSixaxis = true; }'

It looks like bluez doesn't have any maintainers, and a lot of people have touched the bluez derivation, so I'm not sure who to ping about reviewing this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

bluez: Add support for the sixaxis controller
This should add support for the Playstation Dualshock 3 and DualShock 4
controllers.
@veprbl

veprbl approved these changes Dec 15, 2018

@veprbl veprbl merged commit 73c6b3a into NixOS:master Dec 15, 2018

9 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@veprbl

This comment has been minimized.

Copy link
Member

veprbl commented Dec 15, 2018

Honestly, I don't think we need all those options. Arch builds those plugins unconditionally: https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/bluez

@cdepillabout cdepillabout deleted the cdepillabout:add-sixaxis-support-to-bluez branch Dec 15, 2018

@cdepillabout

This comment has been minimized.

Copy link
Contributor

cdepillabout commented Dec 15, 2018

It looks like arch builds them unconditionally, but they are only installed if you install the bluez-plugins package:

https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/bluez#n148

Thanks for merging this BTW!

@cdepillabout cdepillabout referenced this pull request Dec 15, 2018

Merged

Add bluez full package #52168

3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment