Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl_1_1: use the same default CA path as 1.0.* #54438

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
None yet
4 participants
@vcunat
Copy link
Member

commented Jan 21, 2019

Fixes #54437

Motivation for this change

I can't see any motivation for the difference.

It actually seems like Robin wanted to try a higher version quickly without dealing with the non-applying patch, and later noone noticed it was dropped. Still, I may be missing something; e.g. it amazes me how long this has gone without being noticed (?)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all some binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

TODO: perhaps deduplicate the 2x2 patches somehow?

@peti

peti approved these changes Jan 23, 2019

Copy link
Member

left a comment

👍

Thanks for catching this omission!

vcunat added a commit that referenced this pull request Jan 29, 2019

@Profpatsch Profpatsch merged commit 6f61d8b into NixOS:master Jan 29, 2019

13 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nix-build -A openssl_1_1 --argstr system aarch64-linux Build Results
Details
nix-build -A openssl_1_1 --argstr system x86_64-darwin Build Results
Details
nix-build -A openssl_1_1 --argstr system x86_64-linux Build Results
Details

@vcunat vcunat deleted the vcunat:openssl_1_1-ca-path branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.