-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Init mayavi at 4.6.1 #55016
Merged
Merged
WIP: Init mayavi at 4.6.1 #55016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knedlsepp
force-pushed
the
init-mayavi-4.6.2
branch
from
January 31, 2019 22:31
479b97c
to
c4dd20a
Compare
knedlsepp
force-pushed
the
init-mayavi-4.6.2
branch
from
January 31, 2019 23:36
c4dd20a
to
b0002b9
Compare
What is the status of this PR? |
Needs revisiting now that #54525 could solve the problem. |
knedlsepp
force-pushed
the
init-mayavi-4.6.2
branch
from
July 13, 2019 11:57
b0002b9
to
2bf37a9
Compare
knedlsepp
requested review from
edwtjo,
Ericson2314,
LnL7,
matthewbauer,
Mic92,
peti and
ttuegel
as code owners
July 13, 2019 11:57
knedlsepp
force-pushed
the
init-mayavi-4.6.2
branch
from
July 13, 2019 12:02
2bf37a9
to
1f71fa3
Compare
ofborg
bot
added
6.topic: emacs
6.topic: nixos
6.topic: vim
6.topic: xfce
The Xfce Desktop Environment
8.has: module (update)
8.has: clean-up
10.rebuild-darwin: 11-100
10.rebuild-linux: 101-500
and removed
10.rebuild-darwin: 1-10
labels
Jul 13, 2019
knedlsepp
force-pushed
the
init-mayavi-4.6.2
branch
2 times, most recently
from
July 14, 2019 20:44
8fc11d3
to
cb357e9
Compare
knedlsepp
force-pushed
the
init-mayavi-4.6.2
branch
from
November 30, 2019 17:31
cb357e9
to
eb01e61
Compare
ofborg
bot
added
2.status: merge conflict
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
and removed
6.topic: emacs
6.topic: nixos
6.topic: vim
6.topic: xfce
The Xfce Desktop Environment
8.has: module (update)
10.rebuild-darwin: 11-100
10.rebuild-linux: 101-500
labels
Nov 30, 2019
While it may not work, it's in the right direction and I think it's an important package to support, although it is not as popular anymore as it used to be. |
Oh. Thx @FRidh. I forgot about that one already. I'll try to check if applying some wrapqtappshook will solve the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This adds the mayavi package. I originally based this on a commit in June 2018 (1d1a4bf), where the mayavi GUI worked. When I rebased it onto current master, something did break, which now leads to a segmentation fault.
Help is very much appreciated.
Edit:
The segfault seems to be due to some environment impurity (QT maybe?), since it runs fine when inside a
nix-shell -I nixpkgs=$PWD -p python2Packages.mayavi --pure
,Could probably be fixed via: #54525
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)