Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Init mayavi at 4.6.1 #55016

Merged
merged 6 commits into from Feb 9, 2020
Merged

WIP: Init mayavi at 4.6.1 #55016

merged 6 commits into from Feb 9, 2020

Conversation

@knedlsepp
Copy link
Member

@knedlsepp knedlsepp commented Jan 31, 2019

Motivation for this change

This adds the mayavi package. I originally based this on a commit in June 2018 (1d1a4bf), where the mayavi GUI worked. When I rebased it onto current master, something did break, which now leads to a segmentation fault.

Help is very much appreciated.

Edit:
The segfault seems to be due to some environment impurity (QT maybe?), since it runs fine when inside a nix-shell -I nixpkgs=$PWD -p python2Packages.mayavi --pure,
Could probably be fixed via: #54525

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc
Copy link
Contributor

@costrouc costrouc commented Jul 12, 2019

What is the status of this PR?

@knedlsepp
Copy link
Member Author

@knedlsepp knedlsepp commented Jul 12, 2019

Needs revisiting now that #54525 could solve the problem.

@knedlsepp knedlsepp force-pushed the knedlsepp:init-mayavi-4.6.2 branch 2 times, most recently from 8fc11d3 to cb357e9 Jul 13, 2019
@ttuegel ttuegel removed their request for review Sep 28, 2019
@FRidh
Copy link
Member

@FRidh FRidh commented Feb 9, 2020

While it may not work, it's in the right direction and I think it's an important package to support, although it is not as popular anymore as it used to be.

@FRidh FRidh merged commit 1a6e93f into NixOS:master Feb 9, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@knedlsepp
Copy link
Member Author

@knedlsepp knedlsepp commented Feb 9, 2020

Oh. Thx @FRidh. I forgot about that one already. I'll try to check if applying some wrapqtappshook will solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.