Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.imgaug: 0.2.9-patch #67494

Open
wants to merge 2 commits into
base: master
from

Conversation

@Rakesh4G
Copy link

commented Aug 26, 2019

Added patch to bypass opencv-python dependency from imgaug

@CMCDragonkai

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @CMCDragonkai @FRidh

Added patch to bypass opencv-python dependency from imgaug

@CMCDragonkai
@Rakesh4G Rakesh4G changed the title imgaug: 0.2.9-patch pythonPackages.imgaug: 0.2.9-patch Aug 26, 2019
@ofborg ofborg bot added the 6.topic: python label Aug 26, 2019
@Rakesh4G

This comment has been minimized.

Copy link
Author

commented Aug 26, 2019

package has been updated as per inputs from

#61936

aleju/imgaug#379 (comment)

@CMCDragonkai

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

Note that in the master branch of imgaug, the author has changed to opencv-python-headless from opencv-python. See: https://github.com/aleju/imgaug/blob/master/setup.py#L21.

This means for this release 0.2.9, it should work, but the next release may require a change to the substitute patch.

Copy link
Member

left a comment

Approved, looks good. Mark it ready for review.

@Rakesh4G Rakesh4G marked this pull request as ready for review Aug 27, 2019
@Rakesh4G Rakesh4G requested a review from FRidh as a code owner Aug 27, 2019
@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

@GrahamcOfBorg build python37Packages.imgaug

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

Looks like resulting derivation is empty?

[nix-shell:~/.cache/nix-review/pr-67494/results/python37Packages.imgaug]# tree
.
└── nix-support
    └── propagated-build-inputs

1 directory, 1 file
@CMCDragonkai

This comment has been minimized.

Copy link
Member

commented Sep 25, 2019

This is blocked on aleju/imgaug#414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.