Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.colormath: init at 3.0.0 #76962

Merged
merged 1 commit into from Jan 9, 2020
Merged

Conversation

@JonathanReeve
Copy link
Contributor

JonathanReeve commented Jan 5, 2020

Motivation for this change

Add a new python package: colormath

Things done

Just added the new package.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Contributor

jonringer left a comment

also, please squash the commits, there should only be one.

pythonPackages.colormath: init at 3.0.0

you could do:

git reset HEAD~5 # put last five commits into unstaged area
git add pkgs/
git commit -m "pythonPackages.colormath: init at 3.0.0"
git push <fork> <branch> --force

I would also like for you to add yourself as a maintainer :) #76640 is a good example of commit structure :). If you do, the commit history should be:

maintainers: add jonathanreeve
pythonPackages.colormath: init at 3.0.0
@JonathanReeve JonathanReeve force-pushed the JonathanReeve:master branch 3 times, most recently from 10d58ae to 21c30ae Jan 5, 2020
@JonathanReeve
Copy link
Contributor Author

JonathanReeve commented Jan 5, 2020

Ok I think I got it all into one commit now, and added myself as a maintainer.

@jonringer
Copy link
Contributor

jonringer commented Jan 6, 2020

I would also like for you to add yourself as a maintainer :) #76640 is a good example of commit structure :). If you do, the commit history should be:

maintainers: add jonathanreeve
pythonPackages.colormath: init at 3.0.0
attribute 'JonathanReeve' missing, at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-1-lassulus.ewr1.nix.ci/pkgs/development/python-modules/colormath/default.nix:27:21

there should be 2 commits, one adding you as a maintainer in maintainers.nix, and the other adding the package

Copy link
Member

ryantm left a comment

fix ofborg evaluation errors please

@JonathanReeve JonathanReeve force-pushed the JonathanReeve:master branch from 21c30ae to f0ad9b5 Jan 6, 2020
@JonathanReeve
Copy link
Contributor Author

JonathanReeve commented Jan 6, 2020

Oops, it's case sensitive. It should be fixed now. I'm already in the maintainer's list, so that will explain the single commit here.

@jonringer
Copy link
Contributor

jonringer commented Jan 6, 2020

ah, I assumed since you left it out initially that you weren't added. I apologize

@JonathanReeve JonathanReeve force-pushed the JonathanReeve:master branch from f0ad9b5 to 29b7b9d Jan 6, 2020
@JonathanReeve JonathanReeve requested review from ryantm and jonringer and removed request for alyssais and FRidh Jan 6, 2020
Copy link
Contributor

jonringer left a comment

some small nitpicks, otherwise LGTM

@Infinisil Infinisil changed the title Add a new Python package Add python package colormath Jan 6, 2020
@JonathanReeve JonathanReeve force-pushed the JonathanReeve:master branch from e4de0de to 4793e84 Jan 9, 2020
@JonathanReeve
Copy link
Contributor Author

JonathanReeve commented Jan 9, 2020

Cool, I've just made those changes, squashed all the commits, and force-pushed the result.

@JonathanReeve JonathanReeve requested a review from jonringer Jan 9, 2020
@jonringer jonringer changed the title Add python package colormath pythonPackages.colormath: init at 3.0.0 Jan 9, 2020
@jonringer jonringer dismissed ryantm’s stale review Jan 9, 2020

eval works just fine now

Copy link
Contributor

jonringer left a comment

diff LGTM
commit LGTM
has tests 👍

[4 built, 6 copied (42.3 MiB), 6.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76962
3 package were built:
python27Packages.colormath python37Packages.colormath python38Packages.colormath
@jonringer
Copy link
Contributor

jonringer commented Jan 9, 2020

@GrahamcOfBorg build python27Packages.colormath python37Packages.colormath python38Packages.colormath

@jonringer jonringer merged commit e413474 into NixOS:master Jan 9, 2020
13 of 15 checks passed
13 of 15 checks passed
grahamcofborg-eval Calculating Changed Outputs
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.colormath, python37Packages.colormath, python38Packages.colormath on aarch64-linux Success
Details
python27Packages.colormath, python37Packages.colormath, python38Packages.colormath on x86_64-darwin Success
Details
python27Packages.colormath, python37Packages.colormath, python38Packages.colormath on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.