Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gleam: 0.6.0 -> 0.7.1 #81501

Closed
wants to merge 4 commits into from
Closed

gleam: 0.6.0 -> 0.7.1 #81501

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6d9c4b
gleam: 0.6.0 -> 0.7.0
NobbZ Mar 2, 2020
4c25d85
gleam: 0.6.0 -> 0.7.0
NobbZ Mar 2, 2020
ca85e7a
gleam: 0.7.0 -> 0.7.1
NobbZ Mar 8, 2020
d7148b6
Merge branch 'master' into gleam-0.7.0
NobbZ Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkgs/development/compilers/gleam/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
{ stdenv, rustPlatform, fetchFromGitHub, Security }:
{pkgs, stdenv, rustPlatform, fetchFromGitHub, Security }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any usage of pkgs in this file. In nixpkgs, each derivation is called (in pkgs/top-level/all-packages.nix) as

{
  name = callPackage /path/to/derivation { };
}

where callPackage allows to select dependencies via derivation arguments. Thus, you can skip pkgs. If there is any reason for why it is added here, please let me know!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of, course, I just inserted it to have access to pkgs.lib.fakeSha256 during updating the hashes, it was not meant to slip through…


rustPlatform.buildRustPackage rec {
pname = "gleam";
version = "0.6.0";
version = "0.7.0";

src = fetchFromGitHub {
owner = "gleam-lang";
repo = pname;
rev = "v${version}";
sha256 = "1fvy2j6pw1rwm0rg7555q3qg2069cx2b9lk0nsyc3jxsqp9hbn6i";
sha256 = "1l9fdghjgyfc0dxqy3jj0hy7v325ypfj5qd1s4ns0kvy4zn0dzp7";
};

buildInputs = stdenv.lib.optionals stdenv.isDarwin [ Security ];

cargoSha256 = "1vhra9v4jsy9hyhjrmxjy6rnraxz13h1b7l51xvbai5wxsxm7z8m";
cargoSha256 = "0xsna9g5cinkwa3x571rmakc2i68ggwg151rfq8c07wwgp536129";

meta = with stdenv.lib; {
description = "A statically typed language for the Erlang VM";
Expand Down