-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/btrfs autoScrub: don't fail when scrub finishes successfully #84135
Conversation
/marvin opt-in |
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. The stages are
Anybody can switch the current status with a comment of the form Feedback and contributions to this bot are appreciated. |
/status needs-review |
/status needs_review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/status needs_merge
/status needs_merge |
Thanks @symphorien @mdlayher :) |
Oh well, looks like the bot was a bit too enthusiastic here. |
Motivation for this change
I noticed that if a scrub finishes successfully ExecStop is still executed and fails because there is nothing to cancel, marking the service as failed.
cc @schmittlauch
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)