Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] terminator: 1.91 -> 1.92 #86490

Merged
merged 2 commits into from May 1, 2020
Merged

Conversation

@SFrijters
Copy link
Member

SFrijters commented May 1, 2020

Motivation for this change

Backport of #86462 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
SFrijters and others added 2 commits May 1, 2020
(cherry picked from commit 8855c3a)
(cherry picked from commit 64c09a3)
@SFrijters
Copy link
Member Author

SFrijters commented May 1, 2020

Note that a fix was made after the original PR was closed, so this consists of two cherry-picked commits.

@jtojnar
jtojnar approved these changes May 1, 2020
@veprbl veprbl linked an issue that may be closed by this pull request May 1, 2020
@bjornfor bjornfor merged commit 0768366 into NixOS:release-20.03 May 1, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bc0056d"; rev="bc0056d7bef4bba278e4cafc800e6f65b8225a0b"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bc0056d"; rev="bc0056d7bef4bba278e4cafc800e6f65b8225a0b"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bc0056d"; rev="bc0056d7bef4bba278e4cafc800e6f65b8225a0b"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bc0056d"; rev="bc0056d7bef4bba278e4cafc800e6f65b8225a0b"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bc0056d"; rev="bc0056d7bef4bba278e4cafc800e6f65b8225a0b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bc0056d"; rev="bc0056d7bef4bba278e4cafc800e6f65b8225a0b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bc0056d"; rev="bc0056d7bef4bba278e4cafc800e6f65b8225a0b"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
terminator, terminator.passthru.tests on aarch64-linux Success
Details
terminator, terminator.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.