-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xpra: 3.0.9 -> 4.0.2 #88526
Xpra: 3.0.9 -> 4.0.2 #88526
Conversation
From: totaam via IRC:
|
Ok, I backported a patch from the upcoming 4.0.2 which should be removed upon the next version bump. It bypasses the problem with pyxdg (but doesn't fix whatever is going on on nix with XDG_DATA_DIRS and pyxdg. |
9287cc3
to
700615f
Compare
753dce5
to
ee3a1d1
Compare
ee3a1d1
to
66715b5
Compare
@offlinehacker @lourkeur The patch is now in upstream so I've updated the commit. This should be good to merge and backport. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Ensure that the package versioning fits the guidelines.
- Ensure that the commit text fits the guidelines.
- Ensure that the package maintainers are notified.
- Ensure that the meta field information is correct. (Still GPL-2+)
- Ensure that the code contains no typos.
- Building the package locally. (NixOS 20.03, x86_64)
- Function test on my usual workflow: Xpra-over-ssh into a nixos-container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
failures are broken on target branch
https://github.com/NixOS/nixpkgs/pull/88526
1 package failed to build:
ib-controller
2 packages built:
run-scaled xpra
trusting the good word of @lourkeur to have tested the end-to-end scenario :) |
Motivation for this change
Bump xpra version to 4.x series.
cc:
@lourkeur @offlinehacker
Things done
I was having issues with KDE (#88035), which I reported upstream. I patched pyxdg which is now merged in nixpkgs. There is a workaround for pyxdg issues in 4.0.2, which isn't strictly needed anymore, but we should still do the version bump.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)