use upstream hubcaps #624
Merged
use upstream hubcaps #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artturin
force-pushed
the
upstreamhubca
branch
from
92478d0
to
f1abcd5
Compare
Artturin
force-pushed
the
upstreamhubca
branch
from
f1abcd5
to
1eeed03
Compare
Artturin
commented
Nov 15, 2022
Comment on lines
+17
to
+20
| # hyper = { version = "0.14", features = ["full"] } | ||
| hyper = "=0.10.*" | ||
| hyper-native-tls = "0.3.0" | ||
| # maybe can be removed when hyper is updated | ||
| http = "0.2" |
There was a problem hiding this comment.
will take a shot at updating hyper too but in a separate PR
There was a problem hiding this comment.
the release that caused large incompatibilities was hyper 0.11, couldn't figure out a way to update hyper
Artturin
commented
Nov 15, 2022
cole-h
requested changes
Nov 15, 2022
ofborg/src/config.rs
Outdated
| Credentials::Token(self.github.clone().unwrap().token), | ||
| ) | ||
| .unwrap() |
There was a problem hiding this comment.
I'd also really like to see less unwraps (even though I introduced most of these in my quick-n-dirty attempt).
Artturin
force-pushed
the
upstreamhubca
branch
from
9c3a12f
to
5941186
Compare
|
Reminder @cole-h |
cole-h
reviewed
Dec 3, 2022
| @@ -186,10 +183,11 @@ impl GithubAppVendingMachine { | |||
| } | |||
|
|
|||
| fn jwt(&self) -> JWTCredentials { | |||
| JWTCredentials::new(self.conf.app_id, self.conf.private_key.clone()) | |||
| let key = std::fs::read(self.conf.private_key.clone()).expect("Unable to read private_key"); | |||
| JWTCredentials::new(self.conf.app_id, key).expect("Unable to create JWTCredentials") | |||
There was a problem hiding this comment.
Looks like the upstream expects this to be DER (the raw bytes), whereas we used to use PEM (base64-encoded). Required a small change to the ofborg infra, but otherwise works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ran
cargo fmtonrustfmt 1.5.1fixed clippy warnings
fixes #595