Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make new org team codeowner #7

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Make new org team codeowner #7

merged 1 commit into from
Apr 26, 2024

Conversation

infinisil
Copy link
Member

Over time we should assign others, but for now this makes the most sense

@infinisil infinisil requested a review from zimbatm as a code owner April 25, 2024 15:45
@infinisil
Copy link
Member Author

This is not a problem with this PR itself, but it's a good time to address it:

We wanted to switch to GitHub App authentication for the codeowners validation, which would work for https://github.com/mszostok/codeowners-validator, but not the custom script I wrote to check that everybody has write access (which I wrote because it's not supported by codeowners-validator), since the script relies on a GitHub token and it's non-trivial to authenticate as a GitHub App instead.

Well, instead of trying to hack around with more bash, I decided to implement this feature in codeowners-validator instead: mszostok/codeowners-validator#222 😄

Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

@zimbatm
Copy link
Member

zimbatm commented Apr 25, 2024

I think this will have to be force-merged due to the target_pull_request rule

@infinisil
Copy link
Member Author

infinisil commented Apr 25, 2024

I'm not making use of my fix yet, I'll try that soon. Let's not merge until then :)

Edit:

@infinisil infinisil marked this pull request as draft April 25, 2024 21:05
Over time we should assign others, but for now this makes the most sense
@infinisil
Copy link
Member Author

Now that #8 is merged, this passes CI and is ready to be merged :)

@infinisil infinisil marked this pull request as ready for review April 26, 2024 19:18
@infinisil infinisil merged commit cc7f2bc into main Apr 26, 2024
2 checks passed
@infinisil infinisil deleted the org-team branch April 26, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants