-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Time-LLM #908
Add Time-LLM #908
Conversation
…feature/time-llm
…feature/time-llm
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Marco Peixeiro seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome @marcopeix! as a first piece of feedback, could you include a tutorial regarding how to use TimeLLM
? it can be based on experiments/test_timellm/test_timellm.py
, also the tests should be included in models.timellm.ipynb
, (throwing an error if transformers is not installed).
also we should include transformers in the dev requirements to prevent tests from breaking.
I added tests to the notebook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @marcopeix!
could you also include transformers
in the dev_requirements
part of the setttings.ini
file?
also running nbdev_install_git_hooks
and nbdev_clean
should solve the nb_sync
action.
Updated PR according to Azul's comments:
|
…feature/time-llm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome @marcopeix! thank you 🎉
let's wait for the review of @jmoralez or @cchallu to merge it to main❤️
6c1a9e9
to
4cd19a1
Compare
b8c681b
to
6c1a9e9
Compare
Add TimeLLM to neuralforecast.
User can load an LLM from HugginFace and use it for time series forecasting.