Skip to content

Implement buffer growth multiplier #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

rustyconover
Copy link

When dealing with very large redis keys such as 328mb strings
growing the buffer by 3 is very excessive. So if the request
is for larger than 256kb, only grow the buffer by that amount.

When dealing with very large redis keys such as 328mb strings
growing the buffer by 3 is very excessive.  So if the request
is for larger than 256kb, only grow the buffer by that amount.
@BridgeAR BridgeAR closed this in 1af792c Jun 17, 2016
@BridgeAR
Copy link
Member

@rustyconover thanks for bringing this up. I indeed did not consider such huge buffers. Setting the multiplier alone would not have helped in this case though.
The implementation I just pushed is actually a bit faster for big buffers than the former solution and works for the maximum possible typed array size (hiredis can't handle such big buffers btw), so this is a nice side effect 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants