Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort files when creating the solc input #3305

Merged
merged 3 commits into from
Nov 1, 2022

Conversation

fvictorio
Copy link
Member

@fvictorio fvictorio commented Oct 28, 2022

I manually verified that this fixes the problem in the Balancer repo.

I tried to create a fixture project with a synthetic example that reproduces the issue, but it turned out to be way harder than I expected, so I don't have tests for this.

Update: I want to give another try to having a test for this, please don't merge yet.

Update 2: I added a test that triggered the bug. This is ready for review now.

@vercel
Copy link

vercel bot commented Oct 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hardhat ✅ Ready (Inspect) Visit Preview Nov 1, 2022 at 2:19PM (UTC)
hardhat-storybook ✅ Ready (Inspect) Visit Preview Nov 1, 2022 at 2:19PM (UTC)

@linear
Copy link

linear bot commented Oct 28, 2022

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2022

🦋 Changeset detected

Latest commit: c6420a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hardhat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fvictorio fvictorio changed the title Sort files when creating the solc input (WIP) Sort files when creating the solc input Oct 31, 2022
@fvictorio fvictorio removed the request for review from alcuadrado October 31, 2022 19:14
@fvictorio fvictorio changed the title (WIP) Sort files when creating the solc input Sort files when creating the solc input Nov 1, 2022
@alcuadrado
Copy link
Member

Can we release this ASAP? @nventuro is being blocked by it.

@fvictorio fvictorio merged commit 6cb5e0b into main Nov 1, 2022
@fvictorio fvictorio deleted the buildinfo-names-are-not-deterministic-hh-1230 branch November 1, 2022 16:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants