Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter token fix #171

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Jupyter token fix #171

wants to merge 1 commit into from

Conversation

evalieungh
Copy link
Collaborator

to fix #169 Noise in terminal from jupyter server. @MichalTorma do you know if this is a safe fix?

to fix #169 Noise in terminal from jupyter server.
@evalieungh evalieungh requested a review from lasseke March 31, 2023 13:11
@MichalTorma
Copy link
Contributor

Yeah I mean it's not safe, but if you are planing to deploy this only locally, It's not such an issue. To solve it properly, you should use some environmental variable lets say JUPYTER_TOKEN. Then you can have this CMD ["start.sh", "jupyter", "lab", "--LabApp.token=$JUPYTER_TOKEN"] at the end of the Dockerfile. Then you should define JUPYTER_TOKEN var in docker-compose.yml... preferably using .env file. (this .env file should be in .gitignore and not to be pushed to the repo)

@evalieungh
Copy link
Collaborator Author

evalieungh commented Apr 11, 2023

Thanks for the input, then I will change this to a draft PR until I have time to look properly into it. If anyone else is annoyed by the messages, they can use the same hack as me locally but we should not pull this change into main.

@evalieungh evalieungh marked this pull request as draft April 11, 2023 07:23
@evalieungh evalieungh changed the title update Dockerfile Jupyter token fix Jun 12, 2023
@evalieungh evalieungh removed the request for review from lasseke May 23, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jupyter token setup / noise in terminal log from Jupyter server
2 participants