-
Notifications
You must be signed in to change notification settings - Fork 10
Fixes #10738: Parse and store agent type: dsc #107
Fixes #10738: Parse and store agent type: dsc #107
Conversation
val agents = parser.parse("fusion-report/dsc-agent.ocs").node.agents.map(_.name).toList | ||
agents == (DSC_AGENT :: Nil) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a test for the agent version below (in "Agent version" should .... )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually there is no field in software that match, we may need to another path in fusion or even in packaging to install rudder-agent to be available in software, i kept the default value "rudder-agent" but it may not be the case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, we need an other ticket for that.
I clicked on the bad button, it should have been "require changes" |
<RUDDER> | ||
<AGENT> | ||
<AGENT_NAME>windows-dsc</AGENT_NAME> | ||
<CFENGINE_KEY >-----BEGIN RSA PUBLIC KEY----- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have an extra space between CFENGINE_KEY and >
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That has no impact of our inventory parsing but yes i added by hand to have my inventory accepted (and maybe we should change to AGENT_KEY
Commit modified |
7c743dc
to
f42bb25
Compare
OK, merging this PR |
https://www.rudder-project.org/redmine/issues/10738