Skip to content
This repository has been archived by the owner on Feb 7, 2019. It is now read-only.

Conversation

VinceMacBuche
Copy link
Member

val agents = parser.parse("fusion-report/dsc-agent.ocs").node.agents.map(_.name).toList
agents == (DSC_AGENT :: Nil)
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a test for the agent version below (in "Agent version" should .... )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there is no field in software that match, we may need to another path in fusion or even in packaging to install rudder-agent to be available in software, i kept the default value "rudder-agent" but it may not be the case

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, we need an other ticket for that.

@fanf
Copy link
Member

fanf commented May 29, 2017

I clicked on the bad button, it should have been "require changes"

<RUDDER>
<AGENT>
<AGENT_NAME>windows-dsc</AGENT_NAME>
<CFENGINE_KEY >-----BEGIN RSA PUBLIC KEY-----
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have an extra space between CFENGINE_KEY and >

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That has no impact of our inventory parsing but yes i added by hand to have my inventory accepted (and maybe we should change to AGENT_KEY

@VinceMacBuche
Copy link
Member Author

Commit modified

@VinceMacBuche VinceMacBuche force-pushed the ust_10738/parse_and_store_agent_type_dsc branch from 7c743dc to f42bb25 Compare May 30, 2017 12:36
@Normation-Quality-Assistant

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit f42bb25 into Normation:prototype/windows-dsc May 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants