Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #16314: Type for parameters of methods in technique editor #1121

Conversation

VinceMacBuche
Copy link
Member

@VinceMacBuche VinceMacBuche force-pushed the bug_16314/type_for_parameters_of_methods_in_technique_editor branch from 6da455a to 122862f Compare December 4, 2019 23:46
@Normation-Quality-Assistant
Copy link
Contributor

This PR breaks qa-test

-- stdout -- 
Branch 'branches/rudder/6.0' set up to track remote branch 'branches/rudder/6.0' from 'NRM'.
Your branch is up to date with 'NRM/branches/rudder/6.0'.
Already up to date.
Already up to date.
[...]
{'description': 'Name of the package to install', 'name': 'package_name', 'constraints': {'allow_whitespace_string': False, 'allow_empty_string': False, 'max_length': 16384}}

Diff is 659 characters long. Set self.maxDiff to None to see it.

----------------------------------------------------------------------
Ran 16 tests in 2.659s

FAILED (failures=1)
make: *** [Makefile:54: test-common] Error 1

You should run ./qa-test in your repository to make sure it works.
You can also run rudder-dev merge https://github.com/Normation/ncf/pull/1121 --test to test with upmerging.
After this, you can remove the qa: Can't merge ta
-- Your faithful QA (https://ci.normation.com/jenkins/job/merge-accepted-pr/17932/console)

@VinceMacBuche
Copy link
Member Author

Commit modified

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/ncf/pull/1121
-- Your faithful QA
Kant merge: "All our knowledge begins with the senses, proceeds then to the understanding, and ends with reason. There is nothing higher than reason."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/17938/console)

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/ncf/pull/1121
-- Your faithful QA
Kant merge: "Live your life as though your every act were to become a universal law."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/17940/console)

@VinceMacBuche
Copy link
Member Author

OK, squash merging this PR

@VinceMacBuche VinceMacBuche force-pushed the bug_16314/type_for_parameters_of_methods_in_technique_editor branch from fa9f767 to 0f8fdda Compare December 5, 2019 18:35
@VinceMacBuche VinceMacBuche merged commit 0f8fdda into Normation:branches/rudder/6.0 Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants