Fixes #17661: no reports from sharedfile to node if file is already there #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Jun 8, 2020
| "${old_class_prefix}_exist_false" expression => "${old_class_prefix}_exist_repaired"; | ||
| "${class_prefix}_exist_true" expression => "${class_prefix}_exist_kept"; | ||
| "${class_prefix}_exist_false" expression => "${class_prefix}_exist_repaired"; | ||
| "${old_class_prefix}_exist_true" expression => "${old_class_prefix}_exist_kept", scope => "namespace"; |
There was a problem hiding this comment.
Why is this needed? Comment says _classes_combine_ifthenelse defines the outcome classes.
|
Because the class needs to be available in the bundle _classes_combine_ifthenelse
Le 8 juin 2020 22:56:50 GMT+02:00, Alexis Mousset <notifications@github.com> a écrit :
…
@amousset commented on this pull request.
> @@ -127,10 +127,10 @@ bundle agent sharedfile_to_node(target_uuid,
file_id, file_path, ttl)
"${canonified_path}_signed" and => { fileexists("${file_path}.sign"),
isnewerthan("${file_path}.sign","${file_path}") };
# classes for _classes_combine_ifthenelse
- "${old_class_prefix}_exist_true" expression =>
"${old_class_prefix}_exist_kept";
- "${old_class_prefix}_exist_false" expression =>
"${old_class_prefix}_exist_repaired";
- "${class_prefix}_exist_true" expression =>
"${class_prefix}_exist_kept";
- "${class_prefix}_exist_false" expression =>
"${class_prefix}_exist_repaired";
+ "${old_class_prefix}_exist_true" expression =>
"${old_class_prefix}_exist_kept", scope => "namespace";
Why is this needed? Comment says _classes_combine_ifthenelse defines
the outcome classes.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#1215 (review)
--
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
|
|
🤦 indeed |
amousset
approved these changes
Jun 8, 2020
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/17661