Fixes #6436: Adding a carriage return in the description of a technique breaks the generated technique #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue breaks the generated technique
|
PR updated |
VinceMacBuche
force-pushed
the
bug_6436/adding_a_carriage_return_in_the_description_of_a_technique_breaks_the_generated_technique
branch
from
76a03d9
to
369ef16
Compare
| content.append('# @'+ key +" "+ technique[key]) | ||
| for metadata_key in [ 'name', 'description', 'version' ]: | ||
| # Add commentary for each new line in the metadata | ||
| metadata_value = technique[metadata_key].replace("\n", "\n# ") |
There was a problem hiding this comment.
what about \r ? does it matter ? And other special chars ?
fanf
added a commit
that referenced
this pull request
Jun 22, 2015
…_return_in_the_description_of_a_technique_breaks_the_generated_technique Fixes #6436: Adding a carriage return in the description of a technique breaks the generated technique
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/6436