Fixes #7178: Modify generic methods to define and use the new class_prefix #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you rebase this pull request ? |
peckpeck
force-pushed
the
arch_7178/modify_generic_methods_to_define_and_use_the_new_class_prefix
branch
from
1b56765
to
efc65e4
Compare
|
PR updated |
| @@ -49,6 +49,6 @@ bundle agent http_request_check_status_headers(method, url, expected_status, hea | |||
| args => "-I -s -o /dev/null -w \"%{http_code}\" ${url} -X ${method} -H '${headers}' | /bin/grep -q ${expected_status}", | |||
| contain => in_shell, | |||
| # We don't define repaired class, as we only query and expect, so using 999 to avoid using this feature | |||
| classes => classes_generic_return_codes("${old_class_prefix}", "0", "999", "1"); | |||
| classes => classes_generic_return_codes_two("${old_class_prefix}", "${class_prefix}", "0", "999", "1"); | |||
There was a problem hiding this comment.
why changing only this generic method ?
ncharles
added a commit
that referenced
this pull request
Sep 18, 2015
…s_to_define_and_use_the_new_class_prefix Fixes #7178: Modify generic methods to define and use the new class_prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7178