Refs #4343 - Change behavior of service_check_running_ps in order to create all success classes if process match otherwise to create all errors classes #30
Conversation
|
This PR is not mergeable since a bug occurs in |
|
Should be mergeable if #31 is merged before |
|
|
||
| "${service_regex}" | ||
| restart_class => "${class_prefix}_repaired"; | ||
| restart_class => "${service_regex}_checked_not_ok"; |
There was a problem hiding this comment.
In the two above class names, you don't use the ${class_prefix}. A simple convention in ncf is that all classes created must use the ${class_prefix}, to simplify namespace management and avoid conflicts.
Could you re-add the ${class_prefix} in? I don't see that this should cause any trouble, so long as you don't use a class name that might interfere with the result classes.
|
Aside from the two issues I have mentioned (class_prefix and comments), this looks fine. Thanks for another quality PR ! |
…create all success classes if process match otherwise to create all errors classes
|
I didn't see any specific reference of Is it OK for you ? |
|
Yes, thanks for the quick update! Merging. |
…ice_check_running Refs #4343 - Change behavior of service_check_running_ps in order to create all success classes if process match otherwise to create all errors classes
Refs #4343 - Change behavior of service_check_running_ps in order to create all success classes if process match otherwise to create all errors classes
cf http://www.rudder-project.org/redmine/issues/4343