Fixes #8742: Test dry run in ncf #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
changed the title
|
Commit modified |
amousset
force-pushed
the
ust_8742/test_dry_run_of_generic_methods
branch
from
c6ad12f
to
74ae6b6
Compare
|
Fix and test dry-run in ncf, with a self-contained test for each way to enable dry-run and a complete test with a generic method. |
|
Commit modified |
amousset
force-pushed
the
ust_8742/test_dry_run_of_generic_methods
branch
from
74ae6b6
to
dc01284
Compare
|
Ready for review. |
| @@ -56,77 +56,86 @@ bundle agent set_dry_run_mode(mode) | |||
| # - ... and all promise types that are not for the agent | |||
| ############################################################################### | |||
|
|
|||
| body file control | |||
| { | |||
| namespace => "bodydefault"; | |||
There was a problem hiding this comment.
This seems rather an odd name. Can't we use our standard conventions, and have something like "ncf_body_default"?
There was a problem hiding this comment.
No, this is the namespace used in CFEngine for default bodies (https://docs.cfengine.com/latest/reference-language-concepts-bodies.html#default-bodies)
|
Aside from minor naming/indentation comments, this looks great. |
amousset
force-pushed
the
ust_8742/test_dry_run_of_generic_methods
branch
from
dc01284
to
7e66ed8
Compare
|
Commit modified |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/8742